From: David Hildenbrand <david@redhat.com>
To: Tang Yizhou <tangyizhou@huawei.com>
Cc: osalvador@suse.de, mhocko@kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory_hotplug: Add static qualifier for online_policy_to_str
Date: Mon, 13 Sep 2021 10:39:50 +0200 [thread overview]
Message-ID: <db765394-e893-c93d-a54a-52d36a17afd8@redhat.com> (raw)
In-Reply-To: <20210913024534.26161-1-tangyizhou@huawei.com>
On 13.09.21 04:45, Tang Yizhou wrote:
> online_policy_to_str is only used in memory_hotplug.c and should be
> defined as static.
>
> Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>
> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 0488eed3327c..4ea91c3ff768 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -57,7 +57,7 @@ enum {
> ONLINE_POLICY_AUTO_MOVABLE,
> };
>
> -const char *online_policy_to_str[] = {
> +static const char * const online_policy_to_str[] = {
> [ONLINE_POLICY_CONTIG_ZONES] = "contig-zones",
> [ONLINE_POLICY_AUTO_MOVABLE] = "auto-movable",
> };
>
Indeed, thanks
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-09-13 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 2:45 [PATCH] mm/memory_hotplug: Add static qualifier for online_policy_to_str Tang Yizhou
2021-09-13 3:20 ` Muchun Song
2021-09-13 8:39 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db765394-e893-c93d-a54a-52d36a17afd8@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=tangyizhou@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).