From: "Jin, Yao" <firstname.lastname@example.org> To: kajoljain <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Cc: Linuxemail@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v5 0/5] perf stat: Support overall statistics for interval mode Date: Thu, 14 May 2020 21:44:50 +0800 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hi Kajoljain, On 5/14/2020 5:53 PM, kajoljain wrote: > > > On 5/14/20 11:06 AM, Jin Yao wrote: >> Currently perf-stat supports to print counts at regular interval (-I), >> but it's not very easy for user to get the overall statistics. >> >> With this patchset, it supports to report the summary at the end of >> interval output. >> >> For example, >> >> root@kbl-ppc:~# perf stat -e cycles -I1000 --interval-count 2 >> # time counts unit events >> 1.000412064 2,281,114 cycles >> 2.001383658 2,547,880 cycles >> >> Performance counter stats for 'system wide': >> >> 4,828,994 cycles >> >> 2.002860349 seconds time elapsed >> >> root@kbl-ppc:~# perf stat -e cycles,instructions -I1000 --interval-count 2 >> # time counts unit events >> 1.000389902 1,536,093 cycles >> 1.000389902 420,226 instructions # 0.27 insn per cycle >> 2.001433453 2,213,952 cycles >> 2.001433453 735,465 instructions # 0.33 insn per cycle >> >> Performance counter stats for 'system wide': >> >> 3,750,045 cycles >> 1,155,691 instructions # 0.31 insn per cycle >> >> 2.003023361 seconds time elapsed >> >> root@kbl-ppc:~# perf stat -M CPI,IPC -I1000 --interval-count 2 >> # time counts unit events >> 1.000435121 905,303 inst_retired.any # 2.9 CPI >> 1.000435121 2,663,333 cycles >> 1.000435121 914,702 inst_retired.any # 0.3 IPC >> 1.000435121 2,676,559 cpu_clk_unhalted.thread >> 2.001615941 1,951,092 inst_retired.any # 1.8 CPI >> 2.001615941 3,551,357 cycles >> 2.001615941 1,950,837 inst_retired.any # 0.5 IPC >> 2.001615941 3,551,044 cpu_clk_unhalted.thread >> >> Performance counter stats for 'system wide': >> >> 2,856,395 inst_retired.any # 2.2 CPI >> 6,214,690 cycles >> 2,865,539 inst_retired.any # 0.5 IPC >> 6,227,603 cpu_clk_unhalted.thread >> >> 2.003403078 seconds time elapsed > > Hi Jin, > Reporting the summary will be great for understanding overall stats. So, Before the > patch where we are reseting rt_stat before read_counters to make sure, whatever printing > in final aggregate is as per counts on that interval, > Yes, I had similar thoughts, so I posted following patch. https://email@example.com/ > we used to update stats->means and other info as described in > > RFC: https://lkml.org/lkml/2020/3/24/158 > I've checked your patch but sorry I'm also not very sure if it's the expected behavior. > Now, stats->means is same as counts which we are using in generic_metric function. Is this expected behavior? > I am not sure, if data like stats->means and all suppose to update per interval or we are using it somewhere else. > I just think it's easy to understand, that is the metric calculated by the counts per interval. > So, As we call update_stats for each event and for each interval, can we somehow use that > to print overall stats maybe by adding some var in `struct stats` to keep count of total counts for that event. > Please let me know if my understanding is fine. > Adding var in 'struct stats' looks not enough (or more complicated), because perf-stat also needs to report some counts according to different aggregation modes (not only the metric). I just think copying total counts to current counts is a easy way because we can reuse most of existing non-interval processing code. Thanks Jin Yao > Thanks, > Kajol Jain > > > >> >> v5: >> --- >> 1. Create new patch "perf stat: Save aggr value to first member >> of prev_raw_counts". >> >> 2. Call perf_evlist__save_aggr_prev_raw_counts to save aggr value >> to first member of prev_raw_counts for AGGR_GLOBAL. Then next, >> perf_stat_process_counter can create aggr values from per cpu >> values. >> >> Following patches are impacted in v5: >> perf stat: Copy counts from prev_raw_counts to evsel->counts >> perf stat: Save aggr value to first member of prev_raw_counts >> perf stat: Report summary for interval mode >> >> v4: >> --- >> 1. Create runtime_stat_reset. >> >> 2. Zero the aggr in perf_counts__reset and use it to reset >> prev_raw_counts. >> >> 3. Move affinity setup and read_counter_cpu to a new function >> read_affinity_counters. It's only called when stat_config.summary >> is not set. >> >> v3: >> --- >> 1. 'perf stat: Fix wrong per-thread runtime stat for interval mode' >> is a new patch which fixes an existing issue found in test. >> >> 2. We use the prev_raw_counts for summary counts. Drop the summary_counts in v2. >> >> 3. Fix some issues. >> >> v2: >> --- >> Rebase to perf/core branch >> >> Jin Yao (5): >> perf stat: Fix wrong per-thread runtime stat for interval mode >> perf counts: Reset prev_raw_counts counts >> perf stat: Copy counts from prev_raw_counts to evsel->counts >> perf stat: Save aggr value to first member of prev_raw_counts >> perf stat: Report summary for interval mode >> >> tools/perf/builtin-stat.c | 101 ++++++++++++++++++++++++++------------ >> tools/perf/util/counts.c | 4 +- >> tools/perf/util/counts.h | 1 + >> tools/perf/util/stat.c | 43 +++++++++++++--- >> tools/perf/util/stat.h | 3 ++ >> 5 files changed, 113 insertions(+), 39 deletions(-) >>
prev parent reply other threads:[~2020-05-14 13:44 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-14 5:36 Jin Yao 2020-05-14 5:36 ` [PATCH v5 1/5] perf stat: Fix wrong per-thread runtime stat " Jin Yao 2020-05-14 5:36 ` [PATCH v5 2/5] perf counts: Reset prev_raw_counts counts Jin Yao 2020-05-14 5:36 ` [PATCH v5 3/5] perf stat: Copy counts from prev_raw_counts to evsel->counts Jin Yao 2020-05-14 5:36 ` [PATCH v5 4/5] perf stat: Save aggr value to first member of prev_raw_counts Jin Yao 2020-05-18 12:48 ` Jiri Olsa 2020-05-18 14:44 ` Jin, Yao 2020-05-14 5:36 ` [PATCH v5 5/5] perf stat: Report summary for interval mode Jin Yao 2020-05-18 12:47 ` Jiri Olsa 2020-05-19 2:51 ` Jin, Yao 2020-05-14 9:53 ` [PATCH v5 0/5] perf stat: Support overall statistics " kajoljain 2020-05-14 13:44 ` Jin, Yao [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Linuxfirstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v5 0/5] perf stat: Support overall statistics for interval mode' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).