From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: David Miller <davem@davemloft.net>
Cc: sameo@linux.intel.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfc: af_nfc: Fix Spectre v1 vulnerability
Date: Sat, 22 Dec 2018 17:37:35 -0600 [thread overview]
Message-ID: <db8937bf-3dd3-f498-d983-ee98582d9f75@embeddedor.com> (raw)
In-Reply-To: <20181222.150946.778308321544627589.davem@davemloft.net>
On 12/22/18 5:09 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Fri, 21 Dec 2018 15:47:53 -0600
>
>> proto is indirectly controlled by user-space, hence leading to
>> a potential exploitation of the Spectre variant 1 vulnerability.
>>
>> This issue was detected with the help of Smatch:
>>
>> net/nfc/af_nfc.c:42 nfc_sock_create() warn: potential spectre issue 'proto_tab' [w] (local cap)
>>
>> Fix this by sanitizing proto before using it to index proto_tab.
>>
>> Notice that given that speculation windows are large, the policy is
>> to kill the speculation on the first load and not worry if it can be
>> completed with a dependent load/store [1].
>>
>> [1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> I'll take this directly, and queued up for -stable.
>
Dave,
I wonder if you can take this one too:
https://lore.kernel.org/lkml/20181221212229.GA32635@embeddedor/
It's pretty similar to the af_nfc one.
Thanks
--
Gustavo
next prev parent reply other threads:[~2018-12-22 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 21:47 [PATCH] nfc: af_nfc: Fix Spectre v1 vulnerability Gustavo A. R. Silva
2018-12-22 23:09 ` David Miller
2018-12-22 23:37 ` Gustavo A. R. Silva [this message]
2018-12-23 2:42 ` David Miller
2018-12-23 3:03 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db8937bf-3dd3-f498-d983-ee98582d9f75@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).