From: Heiner Kallweit <hkallweit1@gmail.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"
Date: Fri, 6 Apr 2018 21:53:52 +0200 [thread overview]
Message-ID: <dba599ae-6429-1878-c9b6-f29db3a0ab43@gmail.com> (raw)
In-Reply-To: <CAKfTPtAJCck6mpXhbMkZes2D6KMYsoB9WkCRL+6owJfMiNXq5w@mail.gmail.com>
Am 06.04.2018 um 18:03 schrieb Vincent Guittot:
> Hi Heiner,
>
> On 30 March 2018 at 10:37, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>> Am 30.03.2018 um 08:50 schrieb Vincent Guittot:
>>> On 29 March 2018 at 19:40, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>>> Am 29.03.2018 um 09:41 schrieb Vincent Guittot:
>>>
>>>>>
>>>>> I'm finally not so sure that i have the right set up to reproduce the
>>>>> problem as I haven't been able to reproduce it since.
>>>>>
>>>>> Heiner,
>>>>>
>>>>> How fast the problem happens on your board ?
>>>>> Are you doing anything specific on the console that trigger the problem ?
>>>>>
>>>> Hi Vincent,
>>>>
>>>> the lag when working on the console is constantly there, the "rcu_preempt
>>>> detected stalls" happens after several hours (so far always within 24h)
>>>> w/o any triggering event I would be aware of. It occured also when the
>>>> system was idle at that point in time.
>>>
>>> Ok, so I don't have the problem on my hikey as the console never lag
>>> on my setup.
>>>
>>> Can you send me the config of your kernel ? I'd like to check if you
>>> have enable something that could trigger such problem
>>>
>> Sure, he we go. I also add a system log.
>
> Thanks for the config. I have used it for my setup but I can't
> reproduce your regression. My platforms stay stable so I probably
> missing something. Are you facing similar problem with other platforms
> or only this celeron based platform ?
>
Really appreciate your efforts.
Latest linux-next works fine on a Odroid-C2 (arm64, 4 cores) I have.
So the issue may be dual-core and/or platform-specific.
Another possibility could be that it occurs only on relatively slow
CPU's like this Celeron.
> I have reviewed the code but don't see any obvious place in the patch
> that can generate the problem. Nevertheless, would you mind to try the
> patch below ? It's a blind test to try to narrow the problem.
>
I tried your patch, system behavior (with the lagging console) is as before.
Regards, Heiner
> Thanks
>
> ---
> kernel/sched/fair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 0951d1c..e9835f2 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -9794,9 +9794,9 @@ static int idle_balance(struct rq *this_rq,
> struct rq_flags *rf)
> sd = rcu_dereference_check_sched_domain(this_rq->sd);
> if (sd)
> update_next_balance(sd, &next_balance);
> - rcu_read_unlock();
>
> nohz_newidle_balance(this_rq);
> + rcu_read_unlock();
>
> goto out;
> }
>
next prev parent reply other threads:[~2018-04-06 19:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 21:28 Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle" Heiner Kallweit
2018-03-24 6:46 ` Vincent Guittot
2018-03-24 12:47 ` Heiner Kallweit
2018-03-28 10:37 ` Dietmar Eggemann
2018-03-28 14:01 ` Vincent Guittot
2018-03-29 7:41 ` Vincent Guittot
2018-03-29 17:40 ` Heiner Kallweit
2018-03-30 6:50 ` Vincent Guittot
2018-03-30 8:37 ` Heiner Kallweit
2018-04-06 16:03 ` Vincent Guittot
2018-04-06 19:53 ` Heiner Kallweit [this message]
2018-04-09 17:33 ` Heiner Kallweit
2018-04-11 17:00 ` Vincent Guittot
2018-04-11 20:35 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dba599ae-6429-1878-c9b6-f29db3a0ab43@gmail.com \
--to=hkallweit1@gmail.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).