From: Hans Verkuil <hverkuil@xs4all.nl>
To: "Vincent Stehlé" <vincent.stehle@laposte.net>
Cc: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>
Subject: Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument
Date: Thu, 3 Nov 2016 13:47:35 +0100 [thread overview]
Message-ID: <dbaa8b70-ea72-7d9b-176c-6c0a816aaae8@xs4all.nl> (raw)
In-Reply-To: <20161028075253.gdy2bbugih6oqncw@romuald.bergerie>
Hi Vincent,
On 28/10/16 09:52, Vincent Stehlé wrote:
> On Thu, Oct 27, 2016 at 10:23:24PM +0200, Vincent Stehlé wrote:
>> video_device_release() takes a pointer to struct video_device as argument.
>> Fix two call sites where the address of the pointer is passed instead.
>
> Sorry, I messed up: please ignore that "fix". The 0day robot made me
> realize this is indeed not a proper fix.
>
> The issue remains, though: we cannot call video_device_release() on the
> vdev structure member, as this will in turn call kfree(). Most probably,
> vdev needs to be dynamically allocated, or the call to
> video_device_release() dropped completely.
I prefer that vdev is dynamically allocated. There are known problems with
embedded video_device structs, so allocating it is preferred.
Minghsiu, can you do that?
Regards,
Hans
>
> Sorry for the bad patch.
>
> Best regards,
>
> Vincent.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-11-03 12:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 13:09 [PATCH v6 0/6] Add MT8173 MDP Driver Minghsiu Tsai
2016-09-08 13:09 ` [PATCH v6 1/6] VPU: mediatek: Add mdp support Minghsiu Tsai
2016-09-08 13:09 ` [PATCH v6 2/6] dt-bindings: Add a binding for Mediatek MDP Minghsiu Tsai
2016-09-08 13:09 ` [PATCH v6 3/6] media: Add Mediatek MDP Driver Minghsiu Tsai
2016-10-27 20:23 ` [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument Vincent Stehlé
2016-10-27 20:23 ` [PATCH next 2/2] media: mtk-mdp: NULL-terminate mtk_mdp_comp_dt_ids Vincent Stehlé
2016-10-28 7:52 ` [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument Vincent Stehlé
2016-11-03 12:47 ` Hans Verkuil [this message]
2016-11-07 12:47 ` Minghsiu Tsai
2016-09-08 13:09 ` [PATCH v6 4/6] arm64: dts: mediatek: Add MDP for MT8173 Minghsiu Tsai
2016-09-08 13:09 ` [PATCH v6 5/6] media: mtk-mdp: support pixelformat V4L2_PIX_FMT_MT21C Minghsiu Tsai
2016-09-08 13:09 ` [PATCH v6 6/6] media: mtk-mdp: add Maintainers entry for Mediatek MDP driver Minghsiu Tsai
2016-09-14 12:43 ` [PATCH v6 0/6] Add MT8173 MDP Driver Hans Verkuil
2016-09-19 5:55 ` Minghsiu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbaa8b70-ea72-7d9b-176c-6c0a816aaae8@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=hans.verkuil@cisco.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mchehab@s-opensource.com \
--cc=minghsiu.tsai@mediatek.com \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).