From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17FAC433E7 for ; Thu, 15 Oct 2020 16:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8605722210 for ; Thu, 15 Oct 2020 16:07:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389131AbgJOQHj (ORCPT ); Thu, 15 Oct 2020 12:07:39 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36610 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388461AbgJOQHj (ORCPT ); Thu, 15 Oct 2020 12:07:39 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 7D5DE1F45C3D Subject: Re: [PATCH] arm64: dts: mediatek: Add smi_common node for MT8183 To: Matthias Brugger , linux-kernel@vger.kernel.org Cc: Collabora Kernel ML , weiyi.lu@mediatek.com, drinkcat@chromium.org, hsinyi@chromium.org, fparent@baylibre.com, Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20201001162823.3592352-1-enric.balletbo@collabora.com> From: Enric Balletbo i Serra Message-ID: Date: Thu, 15 Oct 2020 18:07:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On 2/10/20 11:17, Matthias Brugger wrote: > > > On 01/10/2020 18:28, Enric Balletbo i Serra wrote: >> The SMI (Smart Multimedia Interface) Common is a bridge between the m4u >> (Multimedia Memory Management Unit) and the Multimedia HW. This block is >> needed to support different multimedia features, like display, video >> decode, and camera. Also is needed to control the power domains of such >> HW blocks. >> >> Signed-off-by: Enric Balletbo i Serra >> --- >> >>   arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++++++++++ >>   1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi >> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi >> index c2fd141afcf6..9082bc65e15e 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi >> @@ -916,6 +916,16 @@ mmsys: syscon@14000000 { >>               #clock-cells = <1>; >>           }; >>   +        smi_common: smi@14019000 { >> +            compatible = "mediatek,mt8183-smi-common", "syscon"; >> +            reg = <0 0x14019000 0 0x1000>; >> +            clocks = <&mmsys CLK_MM_SMI_COMMON>, >> +                 <&mmsys CLK_MM_SMI_COMMON>, >> +                 <&mmsys CLK_MM_GALS_COMM0>, >> +                 <&mmsys CLK_MM_GALS_COMM1>; >> +            clock-names = "apb", "smi", "gals0", "gals1"; >> +        }; >> + > > Having a look at the bindings description, it states that the power-domains > phandle is a required property. Hmmm, this makes me think that there is a kind of circular dependency for MT8183, so MT8183 power domains depends on smi_common and smi_common depends on MT8183 power domains. Will take a deeper look. Thanks Enric > So I suppose you have to base this on the power domains series. > > Regards, > Matthias > >>           imgsys: syscon@15020000 { >>               compatible = "mediatek,mt8183-imgsys", "syscon"; >>               reg = <0 0x15020000 0 0x1000>; >>