From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758467AbcH3Ljv (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 07:39:51 -0400
Received: from cit-hm8-mail01.bmw-carit.de ([212.118.206.84]:64532 "EHLO
        cit-hm8-gw01.bmw-carit.de" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1758420AbcH3Ljt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 07:39:49 -0400
X-CTCH-RefID: str=0001.0A0C0204.57C57081.00EB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0
Subject: Re: [PATCH v4 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF ***
To: Binoy Jayan <binoy.jayan@linaro.org>,
        "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
References: <1472552924-22297-1-git-send-email-binoy.jayan@linaro.org>
CC: Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        <linux-kernel@vger.kernel.org>, Masami <masami.hiramatsu@linaro.org>
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Message-ID: <dbbb4a5c-50ff-2da0-c2bb-166dee1532ea@bmw-carit.de>
Date: Tue, 30 Aug 2016 13:39:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1472552924-22297-1-git-send-email-binoy.jayan@linaro.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.10.50.53]
X-ClientProxiedBy: CIT-HM8-EX01.bmw-carit.intra (10.40.100.13) To
 CIT-HM8-EX01.bmw-carit.intra (10.40.100.13)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Binoy,

On 08/30/2016 12:28 PM, Binoy Jayan wrote:
> Examples of triggers:
> echo 'hist:key=latency.log2:val=hitcount:sort=latency' > /sys/kernel/debug/tracing/events/latency/latency_preempt/trigger
> echo 'hist:key=cpu,latency:val=hitcount:sort=latency if cpu==1' > /sys/kernel/debug/tracing/events/latency/latency_preempt/trigger
> echo 'hist:key=ltype,cpu:val=latency:sort=ltype,cpu if ltype==0' > /sys/kernel/debug/tracing/events/latency/latency_preempt/trigger
>
> Histogram output:
> cat /sys/kernel/debug/tracing/events/latency/latency_preempt/hist

Could you also add couple of test cases to 
tools/testing/selftests/ftrace/test.d/trigger?

Especially the sorting thing you mentioned in the other mail? Obviously 
first we need to figure out what is the expected behavior of it :)

cheers,
daniel