From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Michal Suchanek <msuchanek@suse.de>, linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Firoz Khan <firoz.khan@linaro.org>,
Nicholas Piggin <npiggin@gmail.com>,
Hari Bathini <hbathini@linux.ibm.com>,
Joel Stanley <joel@jms.id.au>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Breno Leitao <leitao@debian.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Allison Randal <allison@lohutok.net>,
Michael Neuling <mikey@neuling.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Disable compat cruft on ppc64le v2
Date: Wed, 28 Aug 2019 13:08:48 +0000 [thread overview]
Message-ID: <dbc5abde-ea15-be43-1fdb-d16052c19e03@c-s.fr> (raw)
In-Reply-To: <cover.1566987936.git.msuchanek@suse.de>
On 08/28/2019 10:30 AM, Michal Suchanek wrote:
> With endian switch disabled by default the ppc64le compat supports
> ppc32le only which is something next to nobody has binaries for.
>
> Less code means less bugs so drop the compat stuff.
>
> I am not particularly sure about the best way to resolve the llseek
> situation. I don't see anything in the syscal tables making it
> 32bit-only so I suppose it should be available on 64bit as well.
>
> This is tested on ppc64le top of
Really ?
I get a build failure with ppc64_defconfig + LITTLE_ENDIAN :
CC arch/powerpc/kernel/signal.o
arch/powerpc/kernel/signal.c: In function 'do_signal':
arch/powerpc/kernel/signal.c:250:6: error: unused variable 'is32'
[-Werror=unused-variable]
int is32 = is_32bit_task();
^~~~
cc1: all warnings being treated as errors
make[3]: *** [arch/powerpc/kernel/signal.o] Error 1
Christophe
>
> https://patchwork.ozlabs.org/cover/1153556/
>
> Changes in v2: saner CONFIG_COMPAT ifdefs
>
> Thanks
>
> Michal
>
> Michal Suchanek (4):
> fs: always build llseek.
> powerpc: move common register copy functions from signal_32.c to
> signal.c
> powerpc/64: make buildable without CONFIG_COMPAT
> powerpc/64: Disable COMPAT if littleendian.
>
> arch/powerpc/Kconfig | 2 +-
> arch/powerpc/include/asm/syscall.h | 2 +
> arch/powerpc/kernel/Makefile | 15 ++-
> arch/powerpc/kernel/entry_64.S | 2 +
> arch/powerpc/kernel/signal.c | 146 ++++++++++++++++++++++++++++-
> arch/powerpc/kernel/signal_32.c | 140 ---------------------------
> arch/powerpc/kernel/syscall_64.c | 5 +-
> arch/powerpc/kernel/vdso.c | 4 +-
> arch/powerpc/perf/callchain.c | 14 ++-
> fs/read_write.c | 2 -
> 10 files changed, 177 insertions(+), 155 deletions(-)
>
next prev parent reply other threads:[~2019-08-28 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 10:30 [PATCH v2 0/4] Disable compat cruft on ppc64le v2 Michal Suchanek
2019-08-28 10:30 ` [PATCH v2 1/4] fs: always build llseek Michal Suchanek
2019-08-28 10:30 ` [PATCH v2 2/4] powerpc: move common register copy functions from signal_32.c to signal.c Michal Suchanek
2019-08-28 10:30 ` [PATCH v2 3/4] powerpc/64: make buildable without CONFIG_COMPAT Michal Suchanek
2019-08-28 12:49 ` Christophe Leroy
2019-08-28 14:29 ` Michal Suchánek
2019-08-28 10:30 ` [PATCH v2 4/4] powerpc/64: Disable COMPAT if littleendian Michal Suchanek
2019-08-28 10:57 ` [PATCH v2 0/4] Disable compat cruft on ppc64le v2 Nicholas Piggin
2019-08-28 14:40 ` Michal Suchánek
2019-08-28 13:08 ` Christophe Leroy [this message]
2019-08-28 14:37 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc5abde-ea15-be43-1fdb-d16052c19e03@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=akpm@linux-foundation.org \
--cc=allison@lohutok.net \
--cc=andrew.donnellan@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=firoz.khan@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hbathini@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=joel@jms.id.au \
--cc=ldv@altlinux.org \
--cc=leitao@debian.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).