From: "André Almeida" <andrealmeid@collabora.com>
To: Helen Koike <helen.koike@collabora.com>, linux-media@vger.kernel.org
Cc: lucmaga@gmail.com, linux-kernel@vger.kernel.org,
lkcamp@lists.libreplanetbr.org, Hans Verkuil <hverkuil@xs4all.nl>,
kernel@collabora.com
Subject: Re: [PATCH 7/8] media: vimc: stream: init/terminate the first entity
Date: Thu, 7 Mar 2019 17:21:41 -0300 [thread overview]
Message-ID: <dbcba9a6-6100-2f21-c95c-963bb1ff9ce6@collabora.com> (raw)
In-Reply-To: <20190306224244.21070-8-helen.koike@collabora.com>
On 3/6/19 7:42 PM, Helen Koike wrote:
> The s_stream callback was not being called for the first entity in the
> stream pipeline array.
> Instead of verifying the type of the node (video or subdevice) and
> calling s_stream from the second entity in the pipeline, do this process
> for all the entities in the pipeline for consistency.
>
> The previous code was not a problem because the first entity is a video
> device and not a subdevice, but this patch prepares vimc to allow
> setting some configuration in the entity before calling s_stream.
>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
Hello,
I've tested the stream (with the default media bus format and using an
alternative one) using a custom user space application and tested all
capture entities using qv4l2 -d /dev/videoX (where X is each of the
capture entities). Also, I have checked v4l2-compliance -d /dev/videoX
and with v4l2-compliance --streaming=5 -d /dev/videoX and no regressions
where found.
Tested-by: André Almeida <andre.almeida@collabora.com>
> ---
>
> drivers/media/platform/vimc/vimc-streamer.c | 25 ++++++++++++---------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-streamer.c b/drivers/media/platform/vimc/vimc-streamer.c
> index b7c1fdef5f0d..5a3bda62fbc8 100644
> --- a/drivers/media/platform/vimc/vimc-streamer.c
> +++ b/drivers/media/platform/vimc/vimc-streamer.c
> @@ -46,19 +46,18 @@ static struct media_entity *vimc_get_source_entity(struct media_entity *ent)
> */
> static void vimc_streamer_pipeline_terminate(struct vimc_stream *stream)
> {
> - struct media_entity *entity;
> + struct vimc_ent_device *ved;
> struct v4l2_subdev *sd;
>
> while (stream->pipe_size) {
> stream->pipe_size--;
> - entity = stream->ved_pipeline[stream->pipe_size]->ent;
> - entity = vimc_get_source_entity(entity);
> + ved = stream->ved_pipeline[stream->pipe_size];
> stream->ved_pipeline[stream->pipe_size] = NULL;
>
> - if (!is_media_entity_v4l2_subdev(entity))
> + if (!is_media_entity_v4l2_subdev(ved->ent))
> continue;
>
> - sd = media_entity_to_v4l2_subdev(entity);
> + sd = media_entity_to_v4l2_subdev(ved->ent);
> v4l2_subdev_call(sd, video, s_stream, 0);
> }
> }
> @@ -89,18 +88,24 @@ static int vimc_streamer_pipeline_init(struct vimc_stream *stream,
> }
> stream->ved_pipeline[stream->pipe_size++] = ved;
>
> + if (is_media_entity_v4l2_subdev(ved->ent)) {
> + sd = media_entity_to_v4l2_subdev(ved->ent);
> + ret = v4l2_subdev_call(sd, video, s_stream, 1);
> + if (ret && ret != -ENOIOCTLCMD) {
> + pr_err("subdev_call error %s\n", ved->ent->name);
> + vimc_streamer_pipeline_terminate(stream);
> + return ret;
> + }
> + }
> +
> entity = vimc_get_source_entity(ved->ent);
> /* Check if the end of the pipeline was reached*/
> if (!entity)
> return 0;
>
> + /* Get the next device in the pipeline */
> if (is_media_entity_v4l2_subdev(entity)) {
> sd = media_entity_to_v4l2_subdev(entity);
> - ret = v4l2_subdev_call(sd, video, s_stream, 1);
> - if (ret && ret != -ENOIOCTLCMD) {
> - vimc_streamer_pipeline_terminate(stream);
> - return ret;
> - }
> ved = v4l2_get_subdevdata(sd);
> } else {
> vdev = container_of(entity,
next prev parent reply other threads:[~2019-03-07 20:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 22:42 [PATCH 0/8] media: vimc: remove media bus code limitation Helen Koike
2019-03-06 22:42 ` [PATCH 1/8] media: vimc: deb: fix default sink bayer format Helen Koike
2019-03-06 22:42 ` [PATCH 2/8] media: vimc: stream: fix thread state before sleep Helen Koike
2019-03-06 22:42 ` [PATCH 3/8] media: vimc: cap: fix step width/height in enum framesize Helen Koike
2019-03-06 22:42 ` [PATCH 4/8] media: v4l2-common: add bayer formats in v4l2_format_info Helen Koike
2019-03-06 22:42 ` [PATCH 5/8] media: vimc: stream: cleanup frame field from struct vimc_stream Helen Koike
2019-03-07 20:19 ` André Almeida
2019-03-06 22:42 ` [PATCH 6/8] media: vimc: stream: add docs to " Helen Koike
2019-03-06 22:42 ` [PATCH 7/8] media: vimc: stream: init/terminate the first entity Helen Koike
2019-03-07 20:21 ` André Almeida [this message]
2019-03-06 22:42 ` [PATCH 8/8] media: vimc: propagate pixel format in the stream Helen Koike
2019-03-07 20:23 ` André Almeida
2019-03-08 13:43 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbcba9a6-6100-2f21-c95c-963bb1ff9ce6@collabora.com \
--to=andrealmeid@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=lucmaga@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).