From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752D0C432BE for ; Fri, 27 Aug 2021 08:14:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 551CD60FDA for ; Fri, 27 Aug 2021 08:14:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244514AbhH0IPD convert rfc822-to-8bit (ORCPT ); Fri, 27 Aug 2021 04:15:03 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.85.151]:38510 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244482AbhH0IPC (ORCPT ); Fri, 27 Aug 2021 04:15:02 -0400 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-110-mwGT8myTNcm83mBe4IfVKA-1; Fri, 27 Aug 2021 09:14:10 +0100 X-MC-Unique: mwGT8myTNcm83mBe4IfVKA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 27 Aug 2021 09:14:09 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.023; Fri, 27 Aug 2021 09:14:08 +0100 From: David Laight To: 'Dan Carpenter' CC: 'Pavel Skripkin' , "Larry.Finger@lwfinger.net" , "phil@philpotter.co.uk" , "gregkh@linuxfoundation.org" , "straube.linux@gmail.com" , "fmdefrancesco@gmail.com" , "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 3/6] staging: r8188eu: add error handling of rtw_read8 Thread-Topic: [PATCH v3 3/6] staging: r8188eu: add error handling of rtw_read8 Thread-Index: AQHXmLmGl/+E/B1vJUGWAidfG7snbKuFdLBA///xloCAAC/eAIAAAKqAgAFtSnA= Date: Fri, 27 Aug 2021 08:14:08 +0000 Message-ID: References: <20210826112745.5e1421ed@gmail.com> <20210826112127.GZ1931@kadam> In-Reply-To: <20210826112127.GZ1931@kadam> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter > Sent: 26 August 2021 12:21 ... > > > > ... > > > > > + len += snprintf(page + len, count - len, > > > > > "rtw_read8(0x%x)=0x%x\n", > > > > > + proc_get_read_addr, (u8) tmp); > > > > > > > > That is broken. > > > > > > > > > > Don't get it, sorry. Previous code did exactly the same thing, but > > > didn't check if read() was successful. > > > > Look up the return value of snprintf(). > > > > It's hard to understand what you are saying. I think you are confusing > libc snprintf with the kernel snprintf? In libc the snprintf function > can return negatives but in the kernel it cannot. This is not going > to change. Any code which checks for negative snprintf returns in the > kernel is wrong and should be fixed. > > Anyway, the code works fine. snprintf here is going to return a number > between 18-32 range. It's not going to overflow the PAGE_SIZE buffer. IIRC it is also in a loop ... Maybe, but the idiom is just broken. Largely the result of snprintf() is never the value you are looking for and should be ignored. Userspace fprintf() is even worse. If you care about the write failing you need to call fflush() and then ferror() (typically before fclose()). Fortunately I've never seen a 'must check' attribute on it. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)