From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E811C433FF for ; Thu, 8 Aug 2019 12:07:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67CB9208C3 for ; Thu, 8 Aug 2019 12:07:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="D9XZBCMi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732277AbfHHMHU (ORCPT ); Thu, 8 Aug 2019 08:07:20 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:40494 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732178AbfHHMHT (ORCPT ); Thu, 8 Aug 2019 08:07:19 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190808120717euoutp0171da541255672c5b4496d3d626949594~48SsV6hSu2803428034euoutp01F for ; Thu, 8 Aug 2019 12:07:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190808120717euoutp0171da541255672c5b4496d3d626949594~48SsV6hSu2803428034euoutp01F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1565266037; bh=i8JGwppC3HzczEgBCKedSj/ArWZ6Yk5+D5tGqqs19EY=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=D9XZBCMiatOhRnT8eu5I3jljotJEzooPefgvXb1kbfFBSdgFls3kpYYzkDiORf5tC vTPqDFDRFDFLbUGGOJ3KEONov3RMxC3R9HFxFqzDeWexlaZpBHCIQYx/JFBVzKg2+W k04BcE8eJsoHj7J4KuA/zi+UVfYedvf8uZ3C+Q1o= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190808120716eucas1p24f95bc266056befb0166718e1f6927ec~48SrW0Hrt1079610796eucas1p2f; Thu, 8 Aug 2019 12:07:16 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 70.B6.04374.4701C4D5; Thu, 8 Aug 2019 13:07:16 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190808120715eucas1p2cb283e1492099f487aa15134de10834f~48SqSneGL0329003290eucas1p2B; Thu, 8 Aug 2019 12:07:15 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190808120715eusmtrp189a4622e9026786067b925c35308545a~48SqETiby2071120711eusmtrp1c; Thu, 8 Aug 2019 12:07:15 +0000 (GMT) X-AuditID: cbfec7f5-4ddff70000001116-0b-5d4c1074bbca Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C6.37.04166.3701C4D5; Thu, 8 Aug 2019 13:07:15 +0100 (BST) Received: from [106.120.51.75] (unknown [106.120.51.75]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190808120714eusmtip21c3ee73d1a4b1879ca4996da685be688~48Spg1Qce2980729807eusmtip2j; Thu, 8 Aug 2019 12:07:14 +0000 (GMT) Subject: Re: [PATCH v2 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, vireshk@kernel.org, devicetree@vger.kernel.org, kgene@kernel.org, pankaj.dubey@samsung.com, "linux-samsung-soc@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?UTF-8?Q?Bart=c5=82omiej_=c5=bbo=c5=82nierkiewicz?= , Marek Szyprowski From: Sylwester Nawrocki Message-ID: Date: Thu, 8 Aug 2019 14:07:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHKsWRmVeSWpSXmKPExsWy7djPc7olAj6xBquvyVtsnLGe1WL+kXOs Fv2PXzNbnD+/gd1i0+NrrBaXd81hs/jce4TRYsb5fUwWa4/cZbdYtPULu0Xr3iPsFpsfHGNz 4PHYtKqTzWPzknqPvi2rGD0+b5ILYInisklJzcksSy3St0vgynjz5TRjwRb+ipXXbrA3MK7i 6WLk5JAQMJFYcaOXHcQWEljBKNG706eLkQvI/sIosXjPanYI5zOjxIvNE5lgOrb072GFSCxn lFj26iBU1VtGiek995lBqoQF4iRe73gL1iEioClx/e93VhCbWWAxs8SnuaYgNpuAoUTv0T5G EJtXwE7iVt9RsHoWARWJ34u7WUBsUYEIiU8PDrNC1AhKnJz5BCzOKRAocaL/ABPETHGJpi8r oebLS2x/O4cZ5CAJgUvsEpvezIQ620XixKELrBC2sMSr41vYIWwZidOTe1ggGpoZJXp232aH cCYwStw/voARospa4vDxi0DdHEArNCXW79KHCDtKbOroYAcJSwjwSdx4KwhxBJ/EpG3TmSHC vBIdbUIQ1UB/rZoOdY6URPeT/ywTGJVmIXltFpJ3ZiF5ZxbC3gWMLKsYxVNLi3PTU4uN81LL 9YoTc4tL89L1kvNzNzECU9Xpf8e/7mDc9yfpEKMAB6MSD++JU96xQqyJZcWVuYcYJTiYlUR4 75V5xgrxpiRWVqUW5ccXleakFh9ilOZgURLnrWZ4EC0kkJ5YkpqdmlqQWgSTZeLglGpg3LAz forWLCN21Vlltz3bjWLluB7MFZrmtDE5n3XqTPm7+n9jBLv3CCf2zPpT9HfZH9WcclWXGX8P 7TCrf1vZWvtu4YXtaS4tO6bfvK3euzu7QkHtQtGanR+LmXa6qP9im9QhFqws36N2t/d85fqC nUlbfsS1WR+d92xXyhSuj7YrC9kPvVu9WomlOCPRUIu5qDgRAAa+xw9RAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsVy+t/xe7rFAj6xBtd3i1hsnLGe1WL+kXOs Fv2PXzNbnD+/gd1i0+NrrBaXd81hs/jce4TRYsb5fUwWa4/cZbdYtPULu0Xr3iPsFpsfHGNz 4PHYtKqTzWPzknqPvi2rGD0+b5ILYInSsynKLy1JVcjILy6xVYo2tDDSM7S00DMysdQzNDaP tTIyVdK3s0lJzcksSy3St0vQy3jz5TRjwRb+ipXXbrA3MK7i6WLk5JAQMJHY0r+HtYuRi0NI YCmjxMWV7WxdjBxACSmJ+S1KEDXCEn+udbFB1LxmlDj+eRNYjbBAnMT8GxkgNSICmhLX/34H m8MssJhZ4sL6+ewgCSGBDiaJq60mIDabgKFE79E+RhCbV8BO4lbfUSYQm0VAReL34m4WEFtU IELi8I5ZUDWCEidnPgGLcwoESpzoPwBWzyygLvFn3iVmCFtcounLSlYIW15i+9s5zBMYhWYh aZ+FpGUWkpZZSFoWMLKsYhRJLS3OTc8tNtQrTswtLs1L10vOz93ECIzMbcd+bt7BeGlj8CFG AQ5GJR7eghPesUKsiWXFlbmHGCU4mJVEeO+VecYK8aYkVlalFuXHF5XmpBYfYjQFem4is5Ro cj4waeSVxBuaGppbWBqaG5sbm1koifN2CByMERJITyxJzU5NLUgtgulj4uCUamC0nLKAk/m/ TmqfONeZnTssenZEWqZzNkj892/MZGyY67Gt+q+kxZGDi+IVcnnlv7gpdn8orNNkL71x4VB2 999VMzzWFaVraWqYzVj3sv8jz/IguTcfulpz9Ls8Y/P352s9vRnZsvNl/Y5sEZEVD9nkPN9e l/hYeMTNckVqUPCe9X3inxVvlCqxFGckGmoxFxUnAgAxJUiO4gIAAA== X-CMS-MailID: 20190808120715eucas1p2cb283e1492099f487aa15134de10834f X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190718143128eucas1p2677ae16d229dddcd9a0db8084f0da5cf X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190718143128eucas1p2677ae16d229dddcd9a0db8084f0da5cf References: <20190718143044.25066-1-s.nawrocki@samsung.com> <20190718143044.25066-3-s.nawrocki@samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/23/19 15:01, Krzysztof Kozlowski wrote: > On Thu, 18 Jul 2019 at 16:31, Sylwester Nawrocki wrote: >> >> Convert the driver to use regmap API in order to allow other >> drivers, like ASV, to access the CHIPID registers. >> >> This patch adds definition of selected CHIPID register offsets >> and register bit fields for Exynos5422 SoC. >> >> Signed-off-by: Sylwester Nawrocki >> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c >> index 78b123ee60c0..594b00488013 100644 >> --- a/drivers/soc/samsung/exynos-chipid.c >> +++ b/drivers/soc/samsung/exynos-chipid.c >> @@ -9,18 +9,16 @@ >> */ >> @@ -53,29 +51,24 @@ static const char * __init product_id_to_soc_id(unsigned int product_id) >> int __init exynos_chipid_early_init(void) >> { >> + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); >> + if (IS_ERR(regmap)) { >> + pr_err("%s: failed to get regmap\n", __func__); > > Other places do not use __func__ prefix so make it consistent. Add it > in patch #1? I would rather drop the function name prefix here, there should be no problem in finding those error messages with grep. I'll just make the above log a bit more specific. >> + return PTR_ERR(regmap); >> } >> diff --git a/include/linux/soc/samsung/exynos-chipid.h b/include/linux/soc/samsung/exynos-chipid.h >> new file mode 100644 >> index 000000000000..25359d70d617 >> --- /dev/null >> +++ b/include/linux/soc/samsung/exynos-chipid.h >> @@ -0,0 +1,48 @@ >> +#define EXYNOS_CHIPID_REG_PRO_ID 0x00 >> + #define EXYNOS_SUBREV_MASK (0xf << 4) > > " #define" is unusual syntax. I think not used anywhere else. Stick to > regular one. Indeed it's almost not used anywhere, I will drop those leading spaces. git grep "^\ #define" *.[ch] | wc -l -- Regards, Sylwester