From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8150BC43217 for ; Thu, 13 Jan 2022 13:28:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235150AbiAMN2x (ORCPT ); Thu, 13 Jan 2022 08:28:53 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:52742 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235138AbiAMN2v (ORCPT ); Thu, 13 Jan 2022 08:28:51 -0500 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id E14D73F17B for ; Thu, 13 Jan 2022 13:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642080529; bh=hznGQk19CD8NoR3VWNyd9c/wYFGozPUj+0yuhJLbQPM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EbB1gurRZOm19CbpS8JjEjYXqWXZ8qLp+KtXwY3G9hHrfMS/ppJam85wXR8J8qvPr aAwZ2C/7JXu+tUJBHzUSbNDho9sPnBYcSRK1NJMuRqy6D5o6QJgfPzYQYKGX40+115 3bqwrR7IYIsT/Cu63Hw4reSe4CSQIfUULTvADyHhRwuSZgKED60f22Zdv6u4wmkbDJ Oq9PVv0QC7WC/tGU6R4ZpLyscwF2JVSQcSqNCgpdj4Exjszam+uOwEYwYY7hmUu3RN 62tO7NLsi+lCdkUPEAjTbfGrL7i/SnW1Sr1g1t4q1o/flgJlFCncyXfdu/Spz+k58H f3GlgTPVpRopA== Received: by mail-ed1-f71.google.com with SMTP id x19-20020a05640226d300b003f8b80f5729so5293387edd.13 for ; Thu, 13 Jan 2022 05:28:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hznGQk19CD8NoR3VWNyd9c/wYFGozPUj+0yuhJLbQPM=; b=RR/yLuDtK+58zFSWRbBwtuyoDWEohCR1PHUZ5lPgcFekhuK9f57nuYa5wSPguMCNIT bBd0r/UN1z0dUCtLowKlDbY8EtohUsm85W9sMMl7FD7hWPovvRStqTwurh5GSAq/U8tG ZxokApYCWW2atyL5w9LrMbkKzhdif7rmlO2yn4X6PUNhxAnewLehbUAme/zz4BG2jcL2 qnRvRg11rFLWfQJwQuDBzOJSPmsNJotWg8xK+AOXD4OXr7MJ6/bbnjgxIGqt0CRJUjAI CWvLDgcweiNl/yx+WeZsGUEmrdbLo9HDY8Ml1icjTJLDpn+3AndqOinfYqjuPGgKFvym n+Tg== X-Gm-Message-State: AOAM533YmxmknqiOzcRX8e9zqr8EchLsxwTriXJrpmuMlmuW/kvSBAOA CUFmdNI1bsoi9cbVw+sddV5aDWzhd8FG1FI89Tx+tCPGdiUFX43MMghYDS9TCnbyyjRSbSjOiiq so0tQR58slplDii8gUIXUN2J86BIT99W8jV8JdcZBQA== X-Received: by 2002:a17:906:a15a:: with SMTP id bu26mr3467344ejb.335.1642080529632; Thu, 13 Jan 2022 05:28:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJxvQFVh8OpoiHGF8vNUoAdSJ/5cDZxtFhJSX77E0+B6EEgX3ZPEv8tzxTe5uuJkZotkBoW/eQ== X-Received: by 2002:a17:906:a15a:: with SMTP id bu26mr3467336ejb.335.1642080529487; Thu, 13 Jan 2022 05:28:49 -0800 (PST) Received: from [192.168.0.30] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id c19sm1178698ede.47.2022.01.13.05.28.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 05:28:48 -0800 (PST) Message-ID: Date: Thu, 13 Jan 2022 14:28:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 18/23] spi: s3c64xx: Add spi port configuration for Tesla FSD SoC Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, linux-fsd@tesla.com, broonie@kernel.org, linux-spi@vger.kernel.org, Aswani Reddy References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-19-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220113121143.22280-19-alim.akhtar@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/01/2022 13:11, Alim Akhtar wrote: > This patch adds compatible and port configuration for > spi controller for Tesla Full Self-Driving SoC. > > Cc: linux-fsd@tesla.com > Cc: broonie@kernel.org > Cc: linux-spi@vger.kernel.org > Signed-off-by: Aswani Reddy > Signed-off-by: Alim Akhtar > --- > drivers/spi/spi-s3c64xx.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 8755cd85e83c..8d0c1f03ab7a 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -1442,6 +1442,16 @@ static const struct s3c64xx_spi_port_config exynos5433_spi_port_config = { > .quirks = S3C64XX_SPI_QUIRK_CS_AUTO, > }; > > +static struct s3c64xx_spi_port_config fsd_spi_port_config = { > + .fifo_lvl_mask = { 0x7f, 0x7f, 0x7f, 0x7f, 0x7f}, > + .rx_lvl_offset = 15, > + .tx_st_done = 25, > + .high_speed = true, > + .clk_from_cmu = true, > + .clk_ioclk = false, > + .quirks = S3C64XX_SPI_QUIRK_CS_AUTO, > +}; > + > static const struct platform_device_id s3c64xx_spi_driver_ids[] = { > { > .name = "s3c2443-spi", > @@ -1472,6 +1482,9 @@ static const struct of_device_id s3c64xx_spi_dt_match[] = { > { .compatible = "samsung,exynos5433-spi", > .data = (void *)&exynos5433_spi_port_config, > }, > + { .compatible = "tesla,fsd-spi", > + .data = (void *)&fsd_spi_port_config, > + }, Looks good, except the discussion about too generic compatible. Best regards, Krzysztof