From: Huang Jianan <huangjianan@oppo.com>
To: Christoph Hellwig <hch@infradead.org>, Gao Xiang <hsiangkao@redhat.com>
Cc: guoweichao@oppo.com, linux-erofs@lists.ozlabs.org,
zhangshiming@oppo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: support direct IO for uncompressed file
Date: Wed, 23 Dec 2020 16:48:20 +0800 [thread overview]
Message-ID: <dc4452e9-83eb-90e7-f001-d39d0ecdd105@oppo.com> (raw)
In-Reply-To: <20201223074455.GA14729@infradead.org>
Hi Christoph,
The reason we use dio is because we need to deploy the patch on some
early kernel versions, and we don't pay much attention to the change of
iomap. Anyway, I will study the problem mentioned by Gao Xiang and try
to convert the current patch to iomap.
Thanks,
Jianan
> On Wed, Dec 23, 2020 at 03:39:01AM +0800, Gao Xiang wrote:
>> Hi Christoph,
>>
>> On Tue, Dec 22, 2020 at 02:22:34PM +0000, Christoph Hellwig wrote:
>>> Please do not add new callers of __blockdev_direct_IO and use the modern
>>> iomap variant instead.
>> We've talked about this topic before. The current status is that iomap
>> doesn't support tail-packing inline data yet (Chao once sent out a version),
>> and erofs only cares about read intrastructure for now (So we don't think
>> more about how to deal with tail-packing inline write path). Plus, the
>> original patch was once lack of inline data regression test from gfs2 folks.
> So resend Chaos prep patch as part of the series switching parts of
> erofs to iomap. We need to move things off the old infrastructure instead
> of adding more users and everyone needs to help a little.
next prev parent reply other threads:[~2020-12-23 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 14:04 [PATCH] erofs: support direct IO for uncompressed file Huang Jianan
2020-12-14 14:04 ` [PATCH] fsstress: support direct IO Huang Jianan
2020-12-22 13:21 ` [PATCH] erofs: support direct IO for uncompressed file Gao Xiang
2020-12-22 14:22 ` Christoph Hellwig
2020-12-22 19:39 ` Gao Xiang
2020-12-23 7:44 ` Christoph Hellwig
2020-12-23 8:48 ` Huang Jianan [this message]
2020-12-23 8:54 ` Christoph Hellwig
2020-12-23 9:03 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc4452e9-83eb-90e7-f001-d39d0ecdd105@oppo.com \
--to=huangjianan@oppo.com \
--cc=guoweichao@oppo.com \
--cc=hch@infradead.org \
--cc=hsiangkao@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).