From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Guenter Roeck <linux@roeck-us.net>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Joerg Roedel <joerg.roedel@amd.com>,
linuxppc-dev@lists.ozlabs.org, Li Yang <leoyang.li@nxp.com>,
Zhang Wei <zw@zh-kernel.org>, Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()
Date: Sat, 29 Aug 2020 17:58:24 +0200 [thread overview]
Message-ID: <dc4491f8-f74c-c3c4-82c4-3986c5352205@csgroup.eu> (raw)
In-Reply-To: <20200829150551.GA27225@roeck-us.net>
Le 29/08/2020 à 17:05, Guenter Roeck a écrit :
> On Sat, Aug 29, 2020 at 02:45:38PM +0200, Luc Van Oostenryck wrote:
>> For ppc32, the functions fsl_ioread64() & fsl_ioread64be()
>> use lower_32_bits() as a fancy way to cast the pointer to u32
>> in order to do non-atomic 64-bit IO.
>>
>> But the pointer is already 32-bit, so simply cast the pointer to u32.
>>
>> This fixes a compile error introduced by
>> ef91bb196b0d ("kernel.h: Silence sparse warning in lower_32_bits")
>>
>> Fixes: ef91bb196b0db1013ef8705367bc2d7944ef696b
>
> checkpatch complains about this and prefers
>
> Fixes: ef91bb196b0d ("kernel.h: Silence sparse warning in lower_32_bits")
Checkpatch also complains about spacing:
CHECK:SPACING: No space is necessary after a cast
#39: FILE: drivers/dma/fsldma.h:208:
+ u32 fsl_addr = (u32) addr;
CHECK:SPACING: No space is necessary after a cast
#48: FILE: drivers/dma/fsldma.h:222:
+ u32 fsl_addr = (u32) addr;
total: 0 errors, 0 warnings, 2 checks, 16 lines checked
Christophe
>
> Otherwise
>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
>
>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> Cc: Li Yang <leoyang.li@nxp.com>
>> Cc: Zhang Wei <zw@zh-kernel.org>
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Cc: Vinod Koul <vkoul@kernel.org>
>> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Cc: dmaengine@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
>> ---
>> drivers/dma/fsldma.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma/fsldma.h b/drivers/dma/fsldma.h
>> index 56f18ae99233..6f6fa7641fa2 100644
>> --- a/drivers/dma/fsldma.h
>> +++ b/drivers/dma/fsldma.h
>> @@ -205,7 +205,7 @@ struct fsldma_chan {
>> #else
>> static u64 fsl_ioread64(const u64 __iomem *addr)
>> {
>> - u32 fsl_addr = lower_32_bits(addr);
>> + u32 fsl_addr = (u32) addr;
>> u64 fsl_addr_hi = (u64)in_le32((u32 *)(fsl_addr + 1)) << 32;
>>
>> return fsl_addr_hi | in_le32((u32 *)fsl_addr);
>> @@ -219,7 +219,7 @@ static void fsl_iowrite64(u64 val, u64 __iomem *addr)
>>
>> static u64 fsl_ioread64be(const u64 __iomem *addr)
>> {
>> - u32 fsl_addr = lower_32_bits(addr);
>> + u32 fsl_addr = (u32) addr;
>> u64 fsl_addr_hi = (u64)in_be32((u32 *)fsl_addr) << 32;
>>
>> return fsl_addr_hi | in_be32((u32 *)(fsl_addr + 1));
>> --
>> 2.28.0
>>
next prev parent reply other threads:[~2020-08-29 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 15:05 [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits() Guenter Roeck
2020-08-29 15:58 ` Christophe Leroy [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-29 10:51 [PATCH] kernel.h: Silence sparse warning in lower_32_bits Guenter Roeck
2020-08-29 12:45 ` [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits() Luc Van Oostenryck
2020-08-29 17:29 ` Linus Torvalds
2020-08-29 20:40 ` Guenter Roeck
2020-08-29 21:20 ` Linus Torvalds
2020-08-31 1:54 ` Michael Ellerman
2020-08-31 6:39 ` Vinod Koul
2020-08-31 14:25 ` Leo Li
2020-08-30 12:11 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc4491f8-f74c-c3c4-82c4-3986c5352205@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=joerg.roedel@amd.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vkoul@kernel.org \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).