From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940879AbdAIUlp (ORCPT ); Mon, 9 Jan 2017 15:41:45 -0500 Received: from mail-it0-f50.google.com ([209.85.214.50]:38687 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940816AbdAIUli (ORCPT ); Mon, 9 Jan 2017 15:41:38 -0500 Subject: Re: [patch] nbd: blk_mq_init_queue returns an error code on failure, not NULL To: Omar Sandoval , Jeff Moyer References: <20170109202707.GA29762@vader.DHCP.thefacebook.com> Cc: Markus Pargmann , linux-block@vger.kernel.org, nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, Josef Bacik From: Jens Axboe Message-ID: Date: Mon, 9 Jan 2017 13:41:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170109202707.GA29762@vader.DHCP.thefacebook.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2017 01:27 PM, Omar Sandoval wrote: > On Mon, Jan 09, 2017 at 03:20:31PM -0500, Jeff Moyer wrote: >> Additionally, don't assign directly to disk->queue, otherwise >> blk_put_queue (called via put_disk) will choke (panic) on the errno >> stored there. >> >> Bug found by code inspection after Omar found a similar issue in >> virtio_blk. Compile-tested only. >> >> Signed-off-by: Jeff Moyer > > Reviewed-by: Omar Sandoval > > Compile-reviewed only :) Josef can probably test it if he cares enough, > but it looks right. Looks good to me, too. Josef, you want me to queue this up directly? -- Jens Axboe