From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E6CC433F5 for ; Sun, 2 Oct 2022 08:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229589AbiJBIPT (ORCPT ); Sun, 2 Oct 2022 04:15:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbiJBIPO (ORCPT ); Sun, 2 Oct 2022 04:15:14 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4646517ABE for ; Sun, 2 Oct 2022 01:15:11 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id o7so5416001lfk.7 for ; Sun, 02 Oct 2022 01:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=s2Uh3PpT13mJBJ1e61WOr6LFLJbasTKO+1hejNf0JLE=; b=G8Azz3hP9CXBtBE70r+A+65q7ULxWW7RN2y0u3zIhkmPtS2nzuDLJhbxrhvbMHpdGo JLmPnJRv2l6Ob3CX5KU7JeTM7KLtYb0xNsTSw5+dG8ECARBt7LR772vanwbvZWKQLDHH cA6wksS99Tlgom9wuzMqaQCXRYMe9MxToDEKm3bpSSH67ysad3D6QTz+VV02PswMOVk2 Es6WKaGusYax+Mq1Qw7WfU/HoFJWGAO9y2g7dwZuWo1B2uHFz9K8fpbDQ0mTqt8Thrpc m7b0/cFCUJ2kvof+03yDdIs0thFrWLMG82fIzPkINnKKbX6tuEVtCCUIAD9Y1JuT6JaB pZlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=s2Uh3PpT13mJBJ1e61WOr6LFLJbasTKO+1hejNf0JLE=; b=y0grdSuCtwI/hAuvG/dSYB9aFgljtRlun/sGir0awgFOgjXyqGGDswpUnPA+2fKUwa pjSkVxGZ92PS1xmAcirJLfLt/0oVzAdsUxMVKlOPdr1LSLkdz/3fNdsCQPVrc0fCpecF 5YQo3YDTSyOnH+7qhY9tvKNfVrXKqGmtGNS7dQeqO0nutOvK6NWMTNxVFAqLAegqiM/6 RpwbZj2+Lxze97MdYr8hRj/thPvggF5YU/XxxX9d0Vscvp4v5jSM9t8MvwZVPZ1ZleuT 5nSR/GhSRcUX+Ox+FTWyrlz5kgwqWzrZ/1IEvGIaEHDUD/jU98s9E3u/7Qx3zpWknDNW Tnuw== X-Gm-Message-State: ACrzQf1f04KDPFFWss/WzkQSSyknOy/Jn1GUP4caQy/NpsTNDMEpq9ti miylE5I4gIcVK1Bj5InwvWSqUw== X-Google-Smtp-Source: AMsMyM4Sj6uZkC2lA6Ka+K7fj8c8gZXyehTdGN5ox47TbrEQoI19qCfeJZhga1vrP3W16jlm3hWlvg== X-Received: by 2002:a05:6512:1047:b0:49d:a875:8d90 with SMTP id c7-20020a056512104700b0049da8758d90mr6007164lfb.630.1664698509667; Sun, 02 Oct 2022 01:15:09 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id d6-20020a2e96c6000000b0026c3ecf9a39sm592594ljj.38.2022.10.02.01.15.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Oct 2022 01:15:09 -0700 (PDT) Message-ID: Date: Sun, 2 Oct 2022 10:15:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm6125: Add GPI DMA nodes Content-Language: en-US To: Martin Botka , martin.botka1@gmail.com Cc: ~postmarketos/upstreaming@lists.sr.ht, Konrad Dybcio , AngeloGioacchino Del Regno , Marijn Suijten , Jami Kettunen , Paul Bouchara , Andy Gross , Bjorn Andersson , Vinod Koul , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221001185526.494095-1-martin.botka@somainline.org> <20221001185526.494095-3-martin.botka@somainline.org> From: Krzysztof Kozlowski In-Reply-To: <20221001185526.494095-3-martin.botka@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/2022 20:55, Martin Botka wrote: > This commit adds and configures GPI DMA nodes. > > Signed-off-by: Martin Botka > --- > arch/arm64/boot/dts/qcom/sm6125.dtsi | 37 ++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi > index d35ea4474234..7e135041bd42 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1076,6 +1077,42 @@ sdhc_2: mmc@4784000 { > status = "disabled"; > }; > > + gpi_dma0: dma-controller@4a00000 { > + compatible = "qcom,sm6125-gpi-dma"; You will need here sdm845 fallback. > + #dma-cells = <5>; > + reg = <0x04a00000 0x60000>; > + iommus = <&apps_smmu 0x0136 0x0>; > + dma-channels = <8>; > + dma-channel-mask = <0x1f>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + ; > + status = "okay"; No need, its okay by default. Both comments apply everywhere. Best regards, Krzysztof