From: Richard Weinberger <richard@nod.at>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Hyunchul Lee <hyc.lee@gmail.com>,
kernel-team@lge.com, Artem Bityutskiy <dedekind1@gmail.com>,
MTD Maling List <linux-mtd@lists.infradead.org>,
david.oberhollenzer@sigma-star.at,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] ubifs: Fix unlink code wrt. double hash lookups
Date: Sun, 16 Jul 2017 14:17:00 +0200 [thread overview]
Message-ID: <dc60f428-9589-e1d1-d903-e8af0d96bf9c@nod.at> (raw)
In-Reply-To: <CAMuHMdUHF-YSZ8=E3u6GRudJfvgpcGHjoEitf6YvrkHqT6guBg@mail.gmail.com>
Geert,
Am 16.07.2017 um 14:12 schrieb Geert Uytterhoeven:
> Hi Richard,
>
> On Sun, Mar 19, 2017 at 9:46 PM, Richard Weinberger <richard@nod.at> wrote:
>> Am 09.03.2017 um 08:04 schrieb Hyunchul Lee:
>>>> - int n, err, type = key_type(c, key);
>>>> - struct ubifs_znode *znode;
>>>> + int err;
>
> fs/ubifs/tnc.c: In function ‘search_dh_cookie’:
> fs/ubifs/tnc.c:1893: warning: ‘err’ is used uninitialized in this function
>
> None of Hyunchul's review comments below ended up in commit 781f675e2d7ec120
> ("ubifs: Fix unlink code wrt. double hash lookups")?
Oh, that was not indented.
Maybe I've selected the wrong patch from patchwork.
Will sort out.
Thanks for pointing out,
//richard
next prev parent reply other threads:[~2017-07-16 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 21:28 [PATCH 1/4] ubifs: Fix data node size for truncating uncompressed nodes Richard Weinberger
2017-02-09 21:28 ` [PATCH 2/4] ubifs: Fix unlink code wrt. double hash lookups Richard Weinberger
2017-03-09 7:04 ` Hyunchul Lee
2017-03-19 20:46 ` Richard Weinberger
2017-07-16 12:12 ` Geert Uytterhoeven
2017-07-16 12:17 ` Richard Weinberger [this message]
2017-07-16 12:19 ` Richard Weinberger
2017-02-09 21:28 ` [PATCH 3/4] ubifs: Add assert to dent_key_init() Richard Weinberger
2017-02-09 21:28 ` [PATCH 4/4] ubifs: Massage debug prints wrt. fscrypt Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc60f428-9589-e1d1-d903-e8af0d96bf9c@nod.at \
--to=richard@nod.at \
--cc=david.oberhollenzer@sigma-star.at \
--cc=dedekind1@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hyc.lee@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).