linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH v2 19/20] media: Kconfig: move the position of sub-driver autoselection
Date: Tue, 24 Mar 2020 14:43:12 +0100	[thread overview]
Message-ID: <dc63b3f9dfa70ce47e305667381c88325472c9f5.1585057134.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1585057134.git.mchehab+huawei@kernel.org>

Let's place the sub-driver-autoselection option just below
the device filtering one, as it also controls a filter menu,
with is not even visible if !EXPERT && !EMBEDDED.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 drivers/media/Kconfig | 50 +++++++++++++++++++++----------------------
 1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 6c55d20458ee..81259287ffa3 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -33,6 +33,28 @@ config MEDIA_SUPPORT_FILTER
 	   needed to support media drivers will be enabled. Also, all
 	   media device drivers should be shown.
 
+config MEDIA_SUBDRV_AUTOSELECT
+	bool "Autoselect ancillary drivers (tuners, sensors, i2c, spi, frontends)"
+	depends on HAS_IOMEM
+	select I2C
+	select I2C_MUX
+	default y if MEDIA_SUPPORT_FILTER
+	help
+	  By default, a media driver auto-selects all possible ancillary
+	  devices such as tuners, sensors, video encoders/decoders and
+	  frontends, that are used by any of the supported devices.
+
+	  This is generally the right thing to do, except when there
+	  are strict constraints with regards to the kernel size,
+	  like on embedded systems.
+
+	  Use this option with care, as deselecting ancillary drivers which
+	  are, in fact, necessary will result in the lack of the needed
+	  functionality for your device (it may not tune or may not have
+	  the needed demodulators).
+
+	  If unsure say Y.
+
 menu "Media device types"
 	visible if MEDIA_SUPPORT_FILTER
 
@@ -191,40 +213,18 @@ source "drivers/media/firewire/Kconfig"
 
 endmenu
 
-menu "Media ancillary drivers (tuners, sensors, i2c, spi, frontends)"
-
 #
 # Ancillary drivers (tuners, i2c, spi, frontends)
 #
 
-config MEDIA_SUBDRV_AUTOSELECT
-	bool "Autoselect ancillary drivers (tuners, sensors, i2c, spi, frontends)"
-	depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_CAMERA_SUPPORT || MEDIA_SDR_SUPPORT
-	depends on HAS_IOMEM
-	select I2C
-	select I2C_MUX
-	default y if !EMBEDDED
-	help
-	  By default, a media driver auto-selects all possible ancillary
-	  devices such as tuners, sensors, video encoders/decoders and
-	  frontends, that are used by any of the supported devices.
-
-	  This is generally the right thing to do, except when there
-	  are strict constraints with regards to the kernel size,
-	  like on embedded systems.
-
-	  Use this option with care, as deselecting ancillary drivers which
-	  are, in fact, necessary will result in the lack of the needed
-	  functionality for your device (it may not tune or may not have
-	  the needed demodulators).
-
-	  If unsure say Y.
-
 config MEDIA_HIDE_ANCILLARY_SUBDRV
 	bool
 	depends on MEDIA_SUBDRV_AUTOSELECT && !COMPILE_TEST && !EXPERT
 	default y
 
+menu "Media ancillary drivers"
+	visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
+
 config MEDIA_ATTACH
 	bool
 	depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_RADIO_SUPPORT
-- 
2.24.1


  parent reply	other threads:[~2020-03-24 13:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24 13:42 [PATCH v2 00/20] Reorganize media Kconfig Mauro Carvalho Chehab
2020-03-24 13:42 ` [PATCH v2 01/20] media: dvb-usb: auto-select CYPRESS_FIRMWARE Mauro Carvalho Chehab
2020-03-24 13:42 ` [PATCH v2 02/20] media: Kconfig: not all V4L2 platform drivers are for camera Mauro Carvalho Chehab
2020-03-24 13:42 ` [PATCH v2 03/20] media: pci: move VIDEO_PCI_SKELETON to a different Kconfig Mauro Carvalho Chehab
2020-03-24 13:42 ` [PATCH v2 04/20] media: reorganize the drivers menu options Mauro Carvalho Chehab
2020-03-24 13:42 ` [PATCH v2 05/20] media: Kconfig: update the MEDIA_SUPPORT help message Mauro Carvalho Chehab
2020-03-24 13:42 ` [PATCH v2 06/20] media: Kconfig: use a sub-menu to select supported devices Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 07/20] media: Kconfig: add an option to filter in/out the embedded drivers Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 08/20] media: split test drivers from platform directory Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 09/20] media: Kconfig: make filtering devices optional Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 10/20] media: Kconfig: move CEC-specific options to cec/Kconfig Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 11/20] media: Kconfig: move comment to siano include Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 12/20] media: Kconfig: move DVB-specific options to dvb-core/Kconfig Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 13/20] media: Kconfig: move V4L2 subdev API to v4l2-core/Kconfig Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 14/20] media: Kconfig: move drivers-specific TTPCI_EEPROM Kconfig var Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 15/20] media: Kconfig: move media controller core select to main Kconfig Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 16/20] media: Kconfig: better organize menu items Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 17/20] media: Kconfig: mode firewire comment to firewire/Kconfig Mauro Carvalho Chehab
2020-03-24 13:43 ` [PATCH v2 18/20] media: Kconfig: place all options under a sub-menu Mauro Carvalho Chehab
2020-03-24 13:43 ` Mauro Carvalho Chehab [this message]
2020-03-24 13:43 ` [PATCH v2 20/20] media: Kconfig: on !EMBEDDED && !EXPERT, enable driver filtering Mauro Carvalho Chehab
2020-03-24 13:53 ` [PATCH v2 00/20] Reorganize media Kconfig Laurent Pinchart
2020-03-24 14:02   ` Mauro Carvalho Chehab
2020-03-24 13:58 ` Hans Verkuil
2020-03-24 14:27   ` Mauro Carvalho Chehab
2020-04-16  9:51 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc63b3f9dfa70ce47e305667381c88325472c9f5.1585057134.git.mchehab+huawei@kernel.org \
    --to=mchehab+huawei@kernel.org \
    --cc=corbet@lwn.net \
    --cc=ezequiel@collabora.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).