From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2845DC433EF for ; Wed, 1 Jun 2022 07:45:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350366AbiFAHpT (ORCPT ); Wed, 1 Jun 2022 03:45:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350418AbiFAHo6 (ORCPT ); Wed, 1 Jun 2022 03:44:58 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE899AE46 for ; Wed, 1 Jun 2022 00:44:53 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id y19so1976323ejq.6 for ; Wed, 01 Jun 2022 00:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=MD6HPERyaclpLbVMS6v8zy/sUdA8rjzF4KgrEmNDbGU=; b=hpCDFNGJOfLdJmn4/pwebhNLUcf3UnAL4E7KtosnNifftBSckZy+8V+W8exyq5uoNf +K8F8gNkChRV6cCtAef34O2RWKyl+1wl88ezP006HV4IGJhwGxk0dHHdeuN8C3Rz1YgW maUsuqUnpfkv8UqYhXaBB0ruMIlsPLytNmnG3tfP5Zt0pEtUa55T02LQZS0zkpO2nKi2 ZewDtrUIfnG7yycAPH7sgryG50SuZIFEBErokp6CHB5IYAN+fkYBIeayEQGecgrVt8Xt C98Zv6CoXoorzOjKSH/PawJqhUAq+hg+y5oV0CPUlMSYbNKw0A9vqdWKBD1Y7XuKCsgG wnVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MD6HPERyaclpLbVMS6v8zy/sUdA8rjzF4KgrEmNDbGU=; b=l6OzWT5NFojlFdm7zBQKVjDCPux8pN2rm8hTfPoosPRUuy4gjPhagXA/SQO5a5wYoB KyEyPzkDkxEPeKc5dyj1NieWZYvT3mZukmPnPKYB+DKbm+JTtCGKT4uO2ScetQeH9QWf dRRQzHQ1Zl4m0+5cOntTjHQzokquXKbth52Tm7/pKggNmEdqXbK+diuvqhwp0jk+RGfv VjCMTwxxFXE6sWJXDo9fxDAMzy5wvCeKtIlg8WOPyTT1ELD2OU/HAdi9MeZsCnMKy/Zs QORzE1MOzzzOG65sdHBITEveM2BL0oBBG0RnRchFwMF5HIY/haWGrOGqcF083tKxx9Y2 HSoA== X-Gm-Message-State: AOAM532Oc/F7d/R+eut2MFCks+gsfjMuvFIn9gshoBZN9gT54b32bcin 5waSStiXP0qV+8PPtvmgkiNaeg== X-Google-Smtp-Source: ABdhPJxhiKO2Cr8rVY6Z7xoEe3aLmQOf+fpslbIVDg4hxcAF04VZVj+2cCeAb+WNtpL5juwTIyioDA== X-Received: by 2002:a17:907:7baa:b0:6fe:b3dc:2378 with SMTP id ne42-20020a1709077baa00b006feb3dc2378mr49731224ejc.266.1654069491828; Wed, 01 Jun 2022 00:44:51 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id fi20-20020a1709073ad400b006fec8e8eff6sm377188ejc.176.2022.06.01.00.44.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 00:44:51 -0700 (PDT) Message-ID: Date: Wed, 1 Jun 2022 09:44:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 4/5] dt-bindings: crypto: add documentation for aspeed hace Content-Language: en-US To: Neal Liu , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Johnny Huang Cc: linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220601054204.1522976-1-neal_liu@aspeedtech.com> <20220601054204.1522976-5-neal_liu@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20220601054204.1522976-5-neal_liu@aspeedtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2022 07:42, Neal Liu wrote: > Add device tree binding documentation for the Aspeed Hash > and Crypto Engines (HACE) Controller. > > Signed-off-by: Neal Liu > Signed-off-by: Johnny Huang > --- > .../bindings/crypto/aspeed,hace.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/aspeed,hace.yaml > > diff --git a/Documentation/devicetree/bindings/crypto/aspeed,hace.yaml b/Documentation/devicetree/bindings/crypto/aspeed,hace.yaml > new file mode 100644 > index 000000000000..36b4ad0dc7fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/aspeed,hace.yaml Filename should be rather from the first compatible, so "aspeed,ast2500-hace.yaml" > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/aspeed,hace.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED HACE hash and crypto Hardware Accelerator Device Tree Bindings s/Device Tree Bindings// > + > +maintainers: > + - Neal Liu > + > +description: | > + The Hash and Crypto Engine (HACE) is designed to accelerate the throughput > + of hash data digest, encryption, and decryption. Basically, HACE can be > + divided into two independently engines - Hash Engine and Crypto Engine. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2500-hace > + - aspeed,ast2600-hace > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + maxItems: 1 You need to list clock names, however usually it does not make sense to have names for just one main device clock. > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + #include > + hace: hace@1e6d0000 { Generic node names so "crypto". > + compatible = "aspeed,ast2600-hace"; > + reg = <0x1e6d0000 0x200>; > + interrupts = <4>; > + clocks = <&syscon ASPEED_CLK_GATE_YCLK>; > + clock-names = "yclk"; > + resets = <&syscon ASPEED_RESET_HACE>; > + }; Best regards, Krzysztof