From: Andrzej Hajda <a.hajda@samsung.com>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>, Rob Clark <robdclark@gmail.com>
Cc: "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Sean Paul <seanpaul@chromium.org>,
Rob Clark <robdclark@chromium.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] drm/bridge: ti-sn65dsi86: correct dsi mode_flags
Date: Thu, 4 Jul 2019 14:33:32 +0200 [thread overview]
Message-ID: <dcb2b28d-38d9-255d-e91f-05e6e713aee0@samsung.com> (raw)
In-Reply-To: <CAOCk7Nq91abTQ02dUNY=8_mgY_kuwU4MFxdO71AjWz1nwUkBGA@mail.gmail.com>
On 02.07.2019 19:23, Jeffrey Hugo wrote:
> On Tue, Jul 2, 2019 at 11:12 AM Rob Clark <robdclark@gmail.com> wrote:
>> On Tue, Jul 2, 2019 at 10:09 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
>>> On Tue, Jul 2, 2019 at 9:46 AM Rob Clark <robdclark@gmail.com> wrote:
>>>> - dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
>>>> - MIPI_DSI_MODE_EOT_PACKET | MIPI_DSI_MODE_VIDEO_HSE;
>>>> + dsi->mode_flags = MIPI_DSI_MODE_VIDEO;
>>> Did you check this against the datasheet? Per my reading, EOT_PACKET
>>> and VIDEO_HSE appear valid. I don't know about VIDEO_SYNC_PULSE.
>> The EOT flat is badly named:
>>
>> /* disable EoT packets in HS mode */
>> #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
>>
>> I can double check out HSE, but this was one of the setting
>> differences between bootloader and kernel
> Ah yeah, you are right. My eyes apparently skipped over the "disable".
>
> If the bootloader is not setting the HSE, then I can't think of a
> reason why we would be having an issue also not setting it.
>
> Seems good to me
>
> Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>
>
Yes, the flags require cleanup.
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
prev parent reply other threads:[~2019-07-04 12:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190702154419.20812-1-robdclark@gmail.com>
2019-07-02 15:44 ` [PATCH 1/3] drm/bridge: ti-sn65dsi86: add link to datasheet Rob Clark
2019-07-02 17:03 ` Jeffrey Hugo
2019-07-04 12:26 ` Andrzej Hajda
2019-07-04 12:32 ` Laurent Pinchart
2019-07-02 15:44 ` [PATCH 2/3] drm/bridge: ti-sn65dsi86: add debugfs Rob Clark
2019-07-02 17:05 ` Jeffrey Hugo
2019-07-04 12:31 ` Andrzej Hajda
2019-07-04 12:35 ` Laurent Pinchart
2019-07-04 13:56 ` Rob Clark
2019-07-04 21:10 ` Laurent Pinchart
2019-07-02 15:44 ` [PATCH 3/3] drm/bridge: ti-sn65dsi86: correct dsi mode_flags Rob Clark
2019-07-02 17:09 ` Jeffrey Hugo
2019-07-02 17:12 ` Rob Clark
2019-07-02 17:23 ` Jeffrey Hugo
2019-07-04 12:33 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcb2b28d-38d9-255d-e91f-05e6e713aee0@samsung.com \
--to=a.hajda@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).