From: lijiang <lijiang@redhat.com>
To: Baoquan He <bhe@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Young <dyoung@redhat.com>
Cc: Petr Tesarik <ptesarik@suse.cz>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, mingo@redhat.com, tglx@linutronix.de
Subject: Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo
Date: Wed, 31 Oct 2018 10:26:23 +0800 [thread overview]
Message-ID: <dcbc925f-6935-6a34-fde1-7aa1ea378891@redhat.com> (raw)
In-Reply-To: <20181030092314.GC14493@MiWiFi-R3L-srv>
在 2018年10月30日 17:23, Baoquan He 写道:
>
> Hi Boris, DaveY and Lianbo,
>
> On 10/30/18 at 10:15am, Borislav Petkov wrote:
>> On Tue, Oct 30, 2018 at 01:09:00PM +0800, Dave Young wrote:
>>> It is not the content, I think it is a good catch from Boris, it would
>>> be good to document the exported things in somewhere eg.
>>> Documentation/kdump/vmcoreinfo.txt
>
> For the vmcoreinfo variables document, I personally think it might be
> not necessary. The reason is that all the old varialbles are exported
> with the name of themselves. We know what they are or what they
> represent since they are all kernel symbols or macro. Only this me_mask,
> it's a local variable and store the value of sme_me_mask for now, may
> store more info later like Petr mentioned, and also will store the memory
> encryption information of TME (which is intel's transparent memory encryption).
> We can add code comment around to tell these.
>
Thank you, everyone.
I personally agree with Baoquan's opinion. What do you think about? Boris and other reviewer?
If the vmcoreinfo document is necessary, would you like to help me to provide an outline?
I can try my best to write the document.
Anyway, we should make a choice.
Regards,
Lianbo
> Personal opinion.
>
> Thanks
> Baoquan
>
next prev parent reply other threads:[~2018-10-31 2:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 9:36 [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo Lianbo Jiang
2018-10-26 9:43 ` Boris Petkov
2018-10-26 12:32 ` lijiang
2018-10-26 16:24 ` Petr Tesarik
2018-10-26 22:25 ` Borislav Petkov
2018-10-27 2:57 ` lijiang
2018-10-27 8:13 ` Baoquan He
2018-10-27 9:10 ` Borislav Petkov
2018-10-27 9:39 ` Baoquan He
2018-10-27 10:12 ` Borislav Petkov
2018-10-27 11:08 ` Baoquan He
2018-10-27 13:17 ` Boris Petkov
2018-10-27 14:41 ` lijiang
2018-10-27 14:51 ` Borislav Petkov
2018-10-29 7:59 ` lijiang
2018-10-29 8:31 ` Baoquan He
2018-10-29 9:29 ` lijiang
2018-10-29 9:57 ` Borislav Petkov
2018-10-29 10:12 ` lijiang
2018-10-29 11:44 ` Baoquan He
2018-10-29 13:41 ` lijiang
2018-10-29 13:49 ` Borislav Petkov
2018-10-30 4:46 ` lijiang
2018-10-30 5:09 ` Dave Young
2018-10-30 9:15 ` Borislav Petkov
2018-10-30 9:23 ` Baoquan He
2018-10-31 2:26 ` lijiang [this message]
2018-10-31 2:47 ` Dave Young
2018-10-31 7:43 ` lijiang
2018-10-31 10:10 ` Borislav Petkov
2018-11-01 15:01 ` Kazuhito Hagio
2018-10-26 16:35 ` Borislav Petkov
2018-10-27 2:19 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcbc925f-6935-6a34-fde1-7aa1ea378891@redhat.com \
--to=lijiang@redhat.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ptesarik@suse.cz \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).