From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Liviu Dudau <Liviu.Dudau@arm.com>,
Anders Roxell <anders.roxell@linaro.org>
Cc: airlied@linux.ie, daniel@ffwll.ch, stable@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: mali-dp: Mark expected switch fall-through
Date: Mon, 29 Jul 2019 05:28:08 -0500 [thread overview]
Message-ID: <dce9bae1-bfd9-1945-f90c-735ef9b0bd07@embeddedor.com> (raw)
In-Reply-To: <20190729095803.hd7ehqjc4zlqztv3@e110455-lin.cambridge.arm.com>
On 7/29/19 4:58 AM, Liviu Dudau wrote:
>> case MW_RESTART:
>> drm_writeback_signal_completion(&malidp->mw_connector, 0);
>> - /* fall through to a new start */
>
> It's a shame that the compiler throws a warning here, it would've been really
> useful to keep the hint that going back to a new start is intentional without
> having to type another comment.
>
You don't have to remove the rest of the comment. For a one-line comment this works
just fine:
/* fall through - to a new start */
--
Gustavo
prev parent reply other threads:[~2019-07-29 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 11:27 [PATCH] drm: mali-dp: Mark expected switch fall-through Anders Roxell
2019-07-29 9:58 ` Liviu Dudau
2019-07-29 10:28 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dce9bae1-bfd9-1945-f90c-735ef9b0bd07@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=anders.roxell@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).