Re: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth

From: Sumit Gupta <sumitg@nvidia.com>
To: kernel test robot <lkp@intel.com>, <treding@nvidia.com>,
	<krzysztof.kozlowski@linaro.org>, <dmitry.osipenko@collabora.com>,
	<viresh.kumar@linaro.org>, <rafael@kernel.org>,
	<jonathanh@nvidia.com>, <robh+dt@kernel.org>,
	<lpieralisi@kernel.org>
Cc: <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<mmaddireddy@nvidia.com>, <kw@linux.com>, <bhelgaas@google.com>,
	<vidyas@nvidia.com>, <sanjayc@nvidia.com>,
	<ksitaraman@nvidia.com>, <ishah@nvidia.com>, <bbasu@nvidia.com>,
	Sumit Gupta <sumitg@nvidia.com>
Subject: Re: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth
Date: Tue, 21 Mar 2023 17:19:49 +0530	[thread overview]
Message-ID: <dcf8b1a9-d0e3-510f-8dc3-5ef9eebb0696@nvidia.com> (raw)
In-Reply-To: <202303211551.eBLRqnv0-lkp@intel.com>

On 21/03/23 13:06, kernel test robot wrote:
> External email: Use caution opening links or attachments
> 
> 
> Hi Sumit,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on robh/for-next]
> [also build test WARNING on krzk-mem-ctrl/for-next pci/next pci/for-linus]
> [cannot apply to tegra/for-next rafael-pm/linux-next linus/master v6.3-rc3 next-20230321]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> patch link:    https://lore.kernel.org/r/20230320182441.11904-8-sumitg%40nvidia.com
> patch subject: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth
> config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230321/202303211551.eBLRqnv0-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/intel-lab-lkp/linux/commit/fa31f117302fc7c15b5d9deeefb8c650554f503d
>          git remote add linux-review https://github.com/intel-lab-lkp/linux
>          git fetch --no-tags linux-review Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112
>          git checkout fa31f117302fc7c15b5d9deeefb8c650554f503d
>          # save the config file
>          mkdir build_dir && cp config build_dir/.config
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/cpufreq/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303211551.eBLRqnv0-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>>> drivers/cpufreq/tegra194-cpufreq.c:397:5: warning: no previous prototype for 'tegra_cpufreq_init_cpufreq_table' [-Wmissing-prototypes]
>       397 | int tegra_cpufreq_init_cpufreq_table(struct cpufreq_policy *policy,
>           |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 

Thank you for the report.

Adding static to the function prototype fixes the warning.
Can we please squash the below change (or) please let me know if i need 
to re-send the patch.

  +++ b/drivers/cpufreq/tegra194-cpufreq.c
  @@ -394,7 +394,7 @@ static unsigned int tegra194_get_speed(u32 cpu)
          return rate;
   }

  -int tegra_cpufreq_init_cpufreq_table(struct cpufreq_policy *policy,
  +static int tegra_cpufreq_init_cpufreq_table(
                             struct cpufreq_policy *policy,
                             struct cpufreq_frequency_table *bpmp_lut,
                             struct cpufreq_frequency_table **opp_table)

Thank you,
Sumit Gupta