From: Waiman Long <longman@redhat.com>
To: Will Deacon <will@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH v2] locking/qspinlock: Fix inaccessible URL of MCS lock paper
Date: Tue, 7 Jan 2020 12:36:36 -0500 [thread overview]
Message-ID: <dd29ceda-cc8f-f418-9cce-1be4e33ae6f1@redhat.com> (raw)
In-Reply-To: <20200107173443.GB32009@willie-the-truck>
On 1/7/20 12:34 PM, Will Deacon wrote:
> On Tue, Jan 07, 2020 at 10:16:19AM -0500, Waiman Long wrote:
>> It turns out that the URL of the MCS lock paper listed in the source
>> code is no longer accessible. I did got question about where the paper
>> was. This patch updates the URL to BZ 206115 which contains a copy of
>> the paper from
>>
>> https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf
>>
>> Signed-off-by: Waiman Long <longman@redhat.com>
>> ---
>> kernel/locking/qspinlock.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c
>> index 2473f10c6956..ce75b2270b58 100644
>> --- a/kernel/locking/qspinlock.c
>> +++ b/kernel/locking/qspinlock.c
>> @@ -31,10 +31,9 @@
>> /*
>> * The basic principle of a queue-based spinlock can best be understood
>> * by studying a classic queue-based spinlock implementation called the
>> - * MCS lock. The paper below provides a good description for this kind
>> - * of lock.
>> + * MCS lock. A copy of the original MCS lock papaer is available at
> s/papaer/paper/
>
> I think I reviewed the previous patch as you sent this version, but please
> could you reword as suggested here [1]?
>
> Cheers,
>
> Will
>
> [1] https://lore.kernel.org/lkml/20200107172343.GA32009@willie-the-truck/T/#m0f9eaf53e509b87d0f6378e35514c9b120d8edc2
>
Sure. I will send out v3 shortly.
Cheers,
Longman
prev parent reply other threads:[~2020-01-07 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 15:16 [PATCH v2] locking/qspinlock: Fix inaccessible URL of MCS lock paper Waiman Long
2020-01-07 17:34 ` Will Deacon
2020-01-07 17:36 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd29ceda-cc8f-f418-9cce-1be4e33ae6f1@redhat.com \
--to=longman@redhat.com \
--cc=bp@alien8.de \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).