linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: cy_huang <u0084500@gmail.com>, broonie@kernel.org
Cc: djrscally@gmail.com, hdegoede@redhat.com, markgross@kernel.org,
	lgirdwood@gmail.com, mcoquelin.stm32@gmail.com,
	alexandre.torgue@foss.st.com, yangyingliang@huawei.com,
	gene_chen@richtek.com, chiaen_wu@richtek.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	ChiYuan Huang <cy_huang@richtek.com>
Subject: Re: [PATCH v2] regulator: core: Use different devices for resource allocation and DT lookup
Date: Tue, 13 Dec 2022 12:32:58 +0100	[thread overview]
Message-ID: <dd329b51-f11a-2af6-9549-c8a014fd5a71@samsung.com> (raw)
In-Reply-To: <1670311341-32664-1-git-send-email-u0084500@gmail.com>

Dear All,

On 06.12.2022 08:22, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Following by the below discussion, there's the potential UAF issue
> between regulator and mfd.
> https://lore.kernel.org/all/20221128143601.1698148-1-yangyingliang@huawei.com/
>
> >From the analysis of Yingliang
>
> CPU A				|CPU B
> mt6370_probe()			|
>    devm_mfd_add_devices()	|
> 				|mt6370_regulator_probe()
> 				|  regulator_register()
> 				|    //allocate init_data and add it to devres
> 				|    regulator_of_get_init_data()
> i2c_unregister_device()		|
>    device_del()			|
>      devres_release_all()	|
>        // init_data is freed	|
>        release_nodes()		|
> 				|  // using init_data causes UAF
> 				|  regulator_register()
>
> It's common to use mfd core to create child device for the regulator.
> In order to do the DT lookup for init data, the child that registered
> the regulator would pass its parent as the parameter. And this causes
> init data resource allocated to its parent, not itself. The issue happen
> when parent device is going to release and regulator core is still doing
> some operation of init data constraint for the regulator of child device.
>
> To fix it, this patch expand 'regulator_register' API to use the
> different devices for init data allocation and DT lookup.
>
> Reported-by: Yang Yingliang <yangyingliang@huawei.com>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>


This patch landed in linux-next 202212 as commit 8f3cbcd6b440 
("regulator: core: Use different devices for resource allocation and DT 
lookup"). Unfortunately it causes serious regression on my test systems. 
It looks that some supplies are not resolved correctly and then turned 
off as 'unused', even if they provide power to other core regulators in 
the system. I've observed this issue on Samsung Chromebook Peach-Pit and 
Peach-Pi (ARM 32bit Exynos based). The symptoms are somehow similar to 
the issue reported here some time ago:

https://lore.kernel.org/all/58b92e75-f373-dae7-7031-8abd465bb874@samsung.com/

I've post more information once I analyze this issue further.


> ---
> loop Yang Yingliang in cc list.
>
> Since v2
> - Fix typo 'int3742' to 'int3472' for kernel build test
>
> ---
>   drivers/platform/x86/intel/int3472/clk_and_regulator.c | 3 ++-
>   drivers/regulator/core.c                               | 8 ++++----
>   drivers/regulator/devres.c                             | 2 +-
>   drivers/regulator/of_regulator.c                       | 2 +-
>   drivers/regulator/stm32-vrefbuf.c                      | 2 +-
>   include/linux/regulator/driver.h                       | 3 ++-
>   6 files changed, 11 insertions(+), 9 deletions(-)
>
> ...

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


  parent reply	other threads:[~2022-12-13 11:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  7:22 [PATCH v2] regulator: core: Use different devices for resource allocation and DT lookup cy_huang
2022-12-08 14:09 ` Mark Brown
     [not found] ` <CGME20221213113259eucas1p1c224898772bc5e59de90c1aa65a34de0@eucas1p1.samsung.com>
2022-12-13 11:32   ` Marek Szyprowski [this message]
2022-12-13 14:19     ` ChiYuan Huang
2022-12-13 14:29       ` Marek Szyprowski
2022-12-13 16:32         ` Mark Brown
2022-12-13 22:23           ` Marek Szyprowski
2022-12-14 13:32             ` Mark Brown
2022-12-14  0:35         ` ChiYuan Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd329b51-f11a-2af6-9549-c8a014fd5a71@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=broonie@kernel.org \
    --cc=chiaen_wu@richtek.com \
    --cc=cy_huang@richtek.com \
    --cc=djrscally@gmail.com \
    --cc=gene_chen@richtek.com \
    --cc=hdegoede@redhat.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=markgross@kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=u0084500@gmail.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).