linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Can Guo <cang@codeaurora.org>
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
	asutoshd@codeaurora.org, jejb@linux.ibm.com,
	martin.petersen@oracle.com, stanley.chu@mediatek.com,
	beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	rjw@rjwysocki.net
Subject: Re: [PATCH v2 2/3] scsi: ufs: Add handling of the return value of pm_runtime_get_sync()
Date: Mon, 04 Jan 2021 18:39:41 +0100	[thread overview]
Message-ID: <dd3a0f2e8c9688f98b1c5a3c843db0570e4da139.camel@gmail.com> (raw)
In-Reply-To: <88069c938a06b06f89cc4662cef3c1be@codeaurora.org>

On Mon, 2020-12-28 at 09:50 +0800, Can Guo wrote:
> > The race issue may exist between UFS access in UFS sysfs context
> > and 
> > UFS
> > shutdown, thus will cause pm_runtime_get_sync() resume failure.
> 
> Are you trying to fix the race condition by adding these checks or
> just
> adding these checks in case pm_runtime_get_sync() fails?
> 
> Can Guo.

Can,
thanks for your review. Sorry, I didn't quite get your point.
This patch is just to add checkup in case pm_runtime_get_sync() failed.

what else should be added?

Bean


  reply	other threads:[~2021-01-04 17:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24 17:20 [PATCH v2 0/3] Two changes of UFS sysfs Bean Huo
2020-12-24 17:20 ` [PATCH v2 1/3] scsi: ufs: Replace sprintf and snprintf with sysfs_emit Bean Huo
2020-12-24 17:20 ` [PATCH v2 2/3] scsi: ufs: Add handling of the return value of pm_runtime_get_sync() Bean Huo
2020-12-28  1:50   ` Can Guo
2021-01-04 17:39     ` Bean Huo [this message]
2020-12-24 17:20 ` [PATCH v2 3/3] scsi: ufs: Let resume callback return -EBUSY after ufshcd_shutdown Bean Huo
2021-01-04 19:26   ` Bean Huo
2021-01-05  1:10   ` Can Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd3a0f2e8c9688f98b1c5a3c843db0570e4da139.camel@gmail.com \
    --to=huobean@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=rjw@rjwysocki.net \
    --cc=stanley.chu@mediatek.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).