linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@fb.com>
To: Peter Zijlstra <peterz@infradead.org>, Song Liu <songliubraving@fb.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"acme@kernel.org" <acme@kernel.org>,
	"ast@kernel.org" <ast@kernel.org>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT
Date: Tue, 8 Jan 2019 20:45:19 +0000	[thread overview]
Message-ID: <dd3ca24b-4da5-b0b1-9d1c-e5ed3fe297d2@fb.com> (raw)
In-Reply-To: <20190108202915.GE30894@hirez.programming.kicks-ass.net>

On 1/8/19 12:29 PM, Peter Zijlstra wrote:
> On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote:
>> The following example shows kernel symbols for a BPF program with 7
>> sub programs:
>>
>>      ffffffffa0257cf9 t bpf_prog_b07ccb89267cf242_F
>>      ffffffffa02592e1 t bpf_prog_2dcecc18072623fc_F
>>      ffffffffa025b0e9 t bpf_prog_bb7a405ebaec5d5c_F
>>      ffffffffa025dd2c t bpf_prog_a7540d4a39ec1fc7_F
>>      ffffffffa025fcca t bpf_prog_05762d4ade0e3737_F
>>      ffffffffa026108f t bpf_prog_db4bd11e35df90d4_F
>>      ffffffffa0263f00 t bpf_prog_89d64e4abf0f0126_F
>>      ffffffffa0257cf9 t bpf_prog_ae31629322c4b018__dummy_tracepoi
> 
> We should probably specify somewhere that the name can include a
> '[module]' part just like normal kallsyms. Even though you don't
> currently use that.

there is no [module] equivalent in bpf land.
The progs loaded by different users can be shared.
There is no strict tree hierarchy (like in modules)
where there is one root and a bunch of function underneath.
In bpf all these functions form a graph and can call each other.
Same with maps that are shared by different progs of different types.
Like networking prog and tracing prog can share common map.

  reply	other threads:[~2019-01-08 20:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20 18:28 [PATCH v5 perf, bpf-next 0/7] reveal invisible bpf programs Song Liu
2018-12-20 18:28 ` [PATCH v5 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL Song Liu
2019-01-08 18:31   ` Peter Zijlstra
2019-01-08 18:56     ` Song Liu
2019-01-08 19:43       ` Peter Zijlstra
2018-12-20 18:28 ` [PATCH v5 perf, bpf-next 2/7] sync tools/include/uapi/linux/perf_event.h Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT Song Liu
2019-01-08 18:41   ` Peter Zijlstra
2019-01-08 19:10     ` Song Liu
2019-01-08 19:43       ` Peter Zijlstra
2019-01-08 23:54         ` Song Liu
2019-01-09 10:18           ` Peter Zijlstra
2019-01-09 11:32             ` Song Liu
2019-01-09 12:59               ` Peter Zijlstra
2019-01-09 16:04                 ` Song Liu
2019-01-08 20:16       ` Arnaldo Carvalho de Melo
2019-01-08 23:37         ` Song Liu
2019-01-08 20:56     ` Alexei Starovoitov
2019-01-08 19:59   ` Peter Zijlstra
2019-01-08 20:29   ` Peter Zijlstra
2019-01-08 20:45     ` Alexei Starovoitov [this message]
2019-01-09 12:41       ` Peter Zijlstra
2019-01-09 15:51         ` Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 4/7] sync tools/include/uapi/linux/perf_event.h Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 5/7] perf util: handle PERF_RECORD_KSYMBOL Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 6/7] perf util: handle PERF_RECORD_BPF_EVENT Song Liu
2018-12-20 18:29 ` [PATCH v5 perf, bpf-next 7/7] perf tools: synthesize PERF_RECORD_* for loaded BPF programs Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd3ca24b-4da5-b0b1-9d1c-e5ed3fe297d2@fb.com \
    --to=ast@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=acme@kernel.org \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).