linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "André Almeida" <andrealmeid@collabora.com>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-doc@vger.kernel.org
Cc: corbet@lwn.net, kernel@collabora.com, krisman@collabora.com,
	jejb@linux.ibm.com, martin.petersen@oracle.com
Subject: Re: [PATCH 2/3] scsi: core: remove trailing whitespaces
Date: Thu, 12 Sep 2019 14:52:19 +0100	[thread overview]
Message-ID: <dd7e8b15-97fc-26bb-7121-bf39e410d8a3@acm.org> (raw)
In-Reply-To: <20190911203735.1332398-2-andrealmeid@collabora.com>

On 9/11/19 9:37 PM, André Almeida wrote:
> Remove all trailing whitespaces from scsi_lib.c

I don't like patches that only change whitespace if no significant
functional changes are included in the same patch series. Such patches
namely pollute the change history, make the output of git log -p and git
blame harder to follow and also cause big trouble for anyone who wants
to rebase his or her own tree with outstanding patches.

Bart.


  reply	other threads:[~2019-09-12 13:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 20:37 [PATCH 1/3] docs: scsi: fix typo André Almeida
2019-09-11 20:37 ` [PATCH 2/3] scsi: core: remove trailing whitespaces André Almeida
2019-09-12 13:52   ` Bart Van Assche [this message]
2019-09-11 20:37 ` [PATCH 3/3] scsi: core: change function comments to kernel-doc style André Almeida
2019-09-12 14:03   ` Bart Van Assche
2019-09-11 21:10 ` [PATCH 1/3] docs: scsi: fix typo Joe Perches
2019-09-11 21:17   ` André Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd7e8b15-97fc-26bb-7121-bf39e410d8a3@acm.org \
    --to=bvanassche@acm.org \
    --cc=andrealmeid@collabora.com \
    --cc=corbet@lwn.net \
    --cc=jejb@linux.ibm.com \
    --cc=kernel@collabora.com \
    --cc=krisman@collabora.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).