From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08CBC4332E for ; Thu, 19 Mar 2020 10:43:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84A4820739 for ; Thu, 19 Mar 2020 10:43:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725767AbgCSKnG (ORCPT ); Thu, 19 Mar 2020 06:43:06 -0400 Received: from relay.sw.ru ([185.231.240.75]:43536 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbgCSKnG (ORCPT ); Thu, 19 Mar 2020 06:43:06 -0400 Received: from [192.168.15.99] by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1jEscu-0005aV-EY; Thu, 19 Mar 2020 13:42:12 +0300 Subject: Re: [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES To: Christoph Hellwig , martin.petersen@oracle.com Cc: axboe@kernel.dk, bob.liu@oracle.com, darrick.wong@oracle.com, agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com, song@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, Chaitanya.Kulkarni@wdc.com, ming.lei@redhat.com, osandov@fb.com, jthumshirn@suse.de, minwoo.im.dev@gmail.com, damien.lemoal@wdc.com, andrea.parri@amarulasolutions.com, hare@suse.com, tj@kernel.org, ajay.joshi@wdc.com, sagi@grimberg.me, dsterba@suse.com, bvanassche@acm.org, dhowells@redhat.com, asml.silence@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <158157930219.111879.12072477040351921368.stgit@localhost.localdomain> <69c0b8a4-656f-98c4-eb55-2fd1184f5fc9@virtuozzo.com> <67d63190-c16f-cd26-6b67-641c8943dc3d@virtuozzo.com> <20200319102819.GA26418@infradead.org> From: Kirill Tkhai Message-ID: Date: Thu, 19 Mar 2020 13:42:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200319102819.GA26418@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.03.2020 13:28, Christoph Hellwig wrote: > On Fri, Mar 13, 2020 at 04:08:58PM +0300, Kirill Tkhai wrote: >> I just don't understand the reason nothing happens :( >> I see newly-sent patches comes fast into block tree. >> But there is only silence... I grepped over Documentation, >> and there is no special rules about block tree. So, >> it looks like standard rules should be applyable. >> >> Some comments? Some requests for reworking? Some personal reasons to ignore my patches? > > I'm still completely opposed to the magic overloading using a flag. > That is just a bad design waiting for trouble to happen. This flag is suggested by Martin Petersen, while the first version of the patchset was based on a separate operation. Since I see only Jens in MAINTAINERS: BLOCK LAYER M: Jens Axboe L: linux-block@vger.kernel.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git S: Maintained F: block/ F: drivers/block/ F: kernel/trace/blktrace.c F: lib/sbitmap.c I expect his comments about final design of this, because both you and Martin are maintainers of another subsystems. I don't want rework this many times until Jens says he wants some third design. I think I'm pretty polite and patient in my waiting, while Jens completely ignores me by some reasons, which are completely unclear for me. I don't think this is completely polite in relation to me. Kirill