linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Alexander Duyck <alexander.duyck@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Cc: Nitesh Narayan Lal <nitesh@redhat.com>,
	kvm list <kvm@vger.kernel.org>,
	Dave Hansen <dave.hansen@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Yang Zhang <yang.zhang.wz@gmail.com>,
	pagupta@redhat.com, Rik van Riel <riel@surriel.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Matthew Wilcox <willy@infradead.org>,
	lcapitulino@redhat.com, wei.w.wang@intel.com,
	Andrea Arcangeli <aarcange@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	dan.j.williams@intel.com,
	Alexander Duyck <alexander.h.duyck@linux.intel.com>,
	Michal Hocko <mhocko@kernel.org>,
	Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v4 6/6] virtio-balloon: Add support for providing unused page reports to host
Date: Mon, 12 Aug 2019 17:49:56 +0200	[thread overview]
Message-ID: <ddb2c4a9-c515-617f-770a-90625c08c829@redhat.com> (raw)
In-Reply-To: <CAKgT0Ucr7GKWsP5sxSbDTtW_7puSqwXDM7y_ZD8i2zNrKNScEw@mail.gmail.com>

On 12.08.19 17:20, Alexander Duyck wrote:
> On Mon, Aug 12, 2019 at 2:53 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>>
>> On Wed, Aug 07, 2019 at 03:42:19PM -0700, Alexander Duyck wrote:
>>> From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> 
> <snip>
> 
>>> --- a/include/uapi/linux/virtio_balloon.h
>>> +++ b/include/uapi/linux/virtio_balloon.h
>>> @@ -36,6 +36,7 @@
>>>  #define VIRTIO_BALLOON_F_DEFLATE_ON_OOM      2 /* Deflate balloon on OOM */
>>>  #define VIRTIO_BALLOON_F_FREE_PAGE_HINT      3 /* VQ to report free pages */
>>>  #define VIRTIO_BALLOON_F_PAGE_POISON 4 /* Guest is using page poisoning */
>>> +#define VIRTIO_BALLOON_F_REPORTING   5 /* Page reporting virtqueue */
>>>
>>>  /* Size of a PFN in the balloon interface. */
>>>  #define VIRTIO_BALLOON_PFN_SHIFT 12
>>
>> Just a small comment: same as any feature bit,
>> or indeed any host/guest interface changes, please
>> CC virtio-dev on any changes to this UAPI file.
>> We must maintain these in the central place in the spec,
>> otherwise we run a risk of conflicts.
>>
> 
> Okay, other than that if I resubmit with the virtio-dev list added to
> you thing this patch set is ready to be acked and pulled into either
> the virtio or mm tree assuming there is no other significant feedback
> that comes in?
> 

I want to take a detailed look at the mm bits (might take a bit but I
don't see a need to rush). I am fine with the page flag we are using.
Hope some other mm people (cc'ing Michal and Oscar) can have a look.

-- 

Thanks,

David / dhildenb

  parent reply	other threads:[~2019-08-12 15:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 22:41 [PATCH v4 0/6] mm / virtio: Provide support for unused page reporting Alexander Duyck
2019-08-07 22:41 ` [PATCH v4 1/6] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-08-07 22:41 ` [PATCH v4 2/6] mm: Move set/get_pcppage_migratetype to mmzone.h Alexander Duyck
2019-08-07 22:42 ` [PATCH v4 3/6] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-08-07 22:42 ` [PATCH v4 4/6] mm: Introduce Reported pages Alexander Duyck
2019-08-08 13:45   ` Nitesh Narayan Lal
2019-08-08 15:11     ` Alexander Duyck
2019-08-07 22:42 ` [PATCH v4 5/6] virtio-balloon: Pull page poisoning config out of free page hinting Alexander Duyck
2019-08-07 22:42 ` [PATCH v4 6/6] virtio-balloon: Add support for providing unused page reports to host Alexander Duyck
2019-08-12  9:53   ` Michael S. Tsirkin
2019-08-12 15:20     ` Alexander Duyck
2019-08-12 15:43       ` Michael S. Tsirkin
2019-08-12 15:49       ` David Hildenbrand [this message]
2019-08-12 16:09         ` Alexander Duyck
2019-08-07 22:43 ` [PATCH v4 QEMU 1/3] virtio-ballon: Implement support for page poison tracking feature Alexander Duyck
2019-08-07 22:43 ` [PATCH v4 QEMU 2/3] virtio-balloon: Add bit to notify guest of unused page reporting Alexander Duyck
2019-08-07 22:43 ` [PATCH v4 QEMU 3/3] virtio-balloon: Provide a interface for " Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddb2c4a9-c515-617f-770a-90625c08c829@redhat.com \
    --to=david@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.duyck@gmail.com \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=lcapitulino@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=nitesh@redhat.com \
    --cc=osalvador@suse.de \
    --cc=pagupta@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=riel@surriel.com \
    --cc=wei.w.wang@intel.com \
    --cc=willy@infradead.org \
    --cc=yang.zhang.wz@gmail.com \
    --subject='Re: [PATCH v4 6/6] virtio-balloon: Add support for providing unused page reports to host' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox