From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C050C432BE for ; Tue, 17 Aug 2021 13:41:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84ABE60FBF for ; Tue, 17 Aug 2021 13:41:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240092AbhHQNm0 (ORCPT ); Tue, 17 Aug 2021 09:42:26 -0400 Received: from mga17.intel.com ([192.55.52.151]:33633 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239981AbhHQNmJ (ORCPT ); Tue, 17 Aug 2021 09:42:09 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10079"; a="196351088" X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="196351088" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 06:39:18 -0700 X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="510474984" Received: from favalosr-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.209.164.120]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 06:39:17 -0700 Subject: Re: [PATCH v5 01/12] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT To: Juergen Gross , Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Andy Lutomirski , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , x86@kernel.org, linux-kernel@vger.kernel.org, Deep Shah , "VMware, Inc." References: <20210804181329.2899708-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210804181329.2899708-2-sathyanarayanan.kuppuswamy@linux.intel.com> <057170db-9382-eb40-7bcb-4ec1de4aae62@suse.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: Date: Tue, 17 Aug 2021 06:39:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/17/21 6:28 AM, Juergen Gross wrote: > I guess you have been lucky and all users of arch_safe_halt() and halt() > are directly or indirectly including asm/paravirt.h by other means. > > There might be configs where this is not true, though. > > In any case I believe you should fix your patch to let asm/irqflags.h > include asm/paravirt.h for the CONFIG_PARAVIRT case. Ok. I will include it. #if defined(CONFIG_PARAVIRT) && !defined(CONFIG_PARAVIRT_XXL) #include #endif -- Sathyanarayanan Kuppuswamy Linux Kernel Developer