From: "吳昊澄 Ricky" <ricky_wu@realtek.com>
To: "arnd@arndb.de" <arnd@arndb.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"vaibhavgupta40@gmail.com" <vaibhavgupta40@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] misc: rtsx: init value of aspm_enabled
Date: Thu, 21 Jan 2021 10:19:50 +0000 [thread overview]
Message-ID: <ddc599eac41b49ca92b1a0e1936c7dc6@realtek.com> (raw)
In-Reply-To: <20210121101604.2258-1-ricky_wu@realtek.com>
Abandon this patch
Sorry~
> -----Original Message-----
> From: 吳昊澄 Ricky <ricky_wu@realtek.com>
> Sent: Thursday, January 21, 2021 6:16 PM
> To: arnd@arndb.de; gregkh@linuxfoundation.org; bhelgaas@google.com; 吳
> 昊澄 Ricky <ricky_wu@realtek.com>; vaibhavgupta40@gmail.com;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] misc: rtsx: init value of aspm_enabled
>
> From: Ricky Wu <ricky_wu@realtek.com>
>
> make sure ASPM state sync with pcr->aspm_enabled init value
> pcr->aspm_enabled
>
> Signed-off-by: Ricky Wu <ricky_wu@realtek.com>
> ---
> drivers/misc/cardreader/rtsx_pcr.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cardreader/rtsx_pcr.c
> b/drivers/misc/cardreader/rtsx_pcr.c
> index 2aa6648fa41f..06df0687c0bb 100644
> --- a/drivers/misc/cardreader/rtsx_pcr.c
> +++ b/drivers/misc/cardreader/rtsx_pcr.c
> @@ -1512,6 +1512,7 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
> struct pcr_handle *handle;
> u32 base, len;
> int ret, i, bar = 0;
> + u8 val;
>
> dev_dbg(&(pcidev->dev),
> ": Realtek PCI-E Card Reader found at %s [%04x:%04x] (rev %x)\n",
> @@ -1577,7 +1578,11 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
> pcr->host_cmds_addr = pcr->rtsx_resv_buf_addr;
> pcr->host_sg_tbl_ptr = pcr->rtsx_resv_buf + HOST_CMDS_BUF_LEN;
> pcr->host_sg_tbl_addr = pcr->rtsx_resv_buf_addr +
> HOST_CMDS_BUF_LEN;
> -
> + rtsx_pci_read_register(pcr, ASPM_FORCE_CTL, &val);
> + if (val & FORCE_ASPM_CTL0 || val & FORCE_ASPM_CTL1)
> + pcr->aspm_enabled = true;
> + else
> + pcr->aspm_enabled = false;
> pcr->card_inserted = 0;
> pcr->card_removed = 0;
> INIT_DELAYED_WORK(&pcr->carddet_work, rtsx_pci_card_detect);
> --
> 2.17.1
next prev parent reply other threads:[~2021-01-21 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 10:16 [PATCH] misc: rtsx: init value of aspm_enabled ricky_wu
2021-01-21 10:19 ` 吳昊澄 Ricky [this message]
2021-01-21 10:35 ricky_wu
2021-01-21 10:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddc599eac41b49ca92b1a0e1936c7dc6@realtek.com \
--to=ricky_wu@realtek.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).