From: Larry Finger <Larry.Finger@lwfinger.net>
To: Saurav Girepunje <saurav.girepunje@gmail.com>,
phil@philpotter.co.uk, gregkh@linuxfoundation.org,
straube.linux@gmail.com, fmdefrancesco@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove goto statement
Date: Mon, 25 Oct 2021 12:26:48 -0500 [thread overview]
Message-ID: <de1bddd8-8e09-4b8f-1fd8-ae9047e60269@lwfinger.net> (raw)
In-Reply-To: <e2020caf-1b0c-ce0e-3d94-d105be85ed38@gmail.com>
On 10/25/21 12:00, Saurav Girepunje wrote:
>
>
> On 25/10/21 8:45 pm, Larry Finger wrote:
>> On 10/25/21 07:15, Saurav Girepunje wrote:
>>> Remove the goto statement from rtw_do_join(). In this function goto
>>> can be replace by return statement. As on goto label exit, function only
>>> return it is not performing any cleanup. Avoiding goto will improve
>>> the function readability.
>>>
>>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>>> ---
>>
> Hi Larry,
>
>> You need to read section 14 of Documentation/process/submitting-patches.rst to learn how to submit a revised patch.
> Resubmitting such a revision using the same subject line is likely to confuse reviewers and maintainers alike, if not patchworks.
>>
> This is original patch (v1). I haven't get any review comment for this patch.
Why did I get it twice? At least I got two messages with that subject line.
Larry
next prev parent reply other threads:[~2021-10-25 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 12:15 [PATCH] staging: r8188eu: core: remove goto statement Saurav Girepunje
2021-10-25 15:15 ` Larry Finger
2021-10-25 17:00 ` Saurav Girepunje
2021-10-25 17:26 ` Larry Finger [this message]
2021-10-25 17:46 ` Saurav Girepunje
2021-11-10 18:17 Saurav Girepunje
2021-11-10 18:45 ` Dan Carpenter
2021-11-13 5:15 ` Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1bddd8-8e09-4b8f-1fd8-ae9047e60269@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).