From: Kishon Vijay Abraham I <kishon@ti.com>
To: Swapnil Jakhade <sjakhade@cadence.com>, <vkoul@kernel.org>,
<linux-kernel@vger.kernel.org>, <maxime@cerno.tech>
Cc: <mparab@cadence.com>, <yamonkar@cadence.com>, <nsekhar@ti.com>,
<tomi.valkeinen@ti.com>, <jsarha@ti.com>, <praneeth@ti.com>
Subject: Re: [PATCH v4 2/2] phy: cadence-torrent: Use kernel PHY API to set PHY attributes
Date: Thu, 23 Jul 2020 10:25:12 +0530 [thread overview]
Message-ID: <de1f7ebe-ce34-c5a3-a911-acd9e27280fc@ti.com> (raw)
In-Reply-To: <1594968633-12535-3-git-send-email-sjakhade@cadence.com>
On 7/17/2020 12:20 PM, Swapnil Jakhade wrote:
> Use generic PHY framework function phy_set_attrs() to set number
> of lanes and maximum link rate supported by PHY.
>
> Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/phy/cadence/phy-cadence-torrent.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c
> index 7116127358ee..af81707ff0c6 100644
> --- a/drivers/phy/cadence/phy-cadence-torrent.c
> +++ b/drivers/phy/cadence/phy-cadence-torrent.c
> @@ -1710,6 +1710,7 @@ static int cdns_torrent_phy_probe(struct platform_device *pdev)
> struct cdns_torrent_phy *cdns_phy;
> struct device *dev = &pdev->dev;
> struct phy_provider *phy_provider;
> + struct phy_attrs torrent_attr;
> const struct of_device_id *match;
> struct cdns_torrent_data *data;
> struct device_node *child;
> @@ -1852,6 +1853,12 @@ static int cdns_torrent_phy_probe(struct platform_device *pdev)
> cdns_phy->phys[node].num_lanes,
> cdns_phy->max_bit_rate / 1000,
> cdns_phy->max_bit_rate % 1000);
> +
> + torrent_attr.bus_width = cdns_phy->phys[node].num_lanes;
> + torrent_attr.max_link_rate = cdns_phy->max_bit_rate;
> + torrent_attr.mode = PHY_MODE_DP;
> +
> + phy_set_attrs(gphy, torrent_attr);
> } else {
> dev_err(dev, "Driver supports only PHY_TYPE_DP\n");
> ret = -ENOTSUPP;
>
next prev parent reply other threads:[~2020-07-23 4:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 6:50 [PATCH v4 0/2] Add new PHY APIs to framework to get/set PHY attributes Swapnil Jakhade
2020-07-17 6:50 ` [PATCH v4 1/2] phy: Add new PHY attribute max_link_rate and APIs " Swapnil Jakhade
2020-07-23 4:51 ` Kishon Vijay Abraham I
2020-08-11 0:20 ` Laurent Pinchart
2020-07-17 6:50 ` [PATCH v4 2/2] phy: cadence-torrent: Use kernel PHY API to set " Swapnil Jakhade
2020-07-23 4:55 ` Kishon Vijay Abraham I [this message]
2020-07-25 19:54 ` [PATCH v4 0/2] Add new PHY APIs to framework to get/set " Sekhar Nori
2020-07-27 9:55 ` Vinod Koul
2020-07-27 17:02 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1f7ebe-ce34-c5a3-a911-acd9e27280fc@ti.com \
--to=kishon@ti.com \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mparab@cadence.com \
--cc=nsekhar@ti.com \
--cc=praneeth@ti.com \
--cc=sjakhade@cadence.com \
--cc=tomi.valkeinen@ti.com \
--cc=vkoul@kernel.org \
--cc=yamonkar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).