linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] remoteproc: pru: Enable PRU cores on K3 AM62x SoCs
@ 2022-04-27  8:35 Kishon Vijay Abraham I
  2022-04-27  8:35 ` [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for " Kishon Vijay Abraham I
  2022-04-27  8:35 ` [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on " Kishon Vijay Abraham I
  0 siblings, 2 replies; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2022-04-27  8:35 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski
  Cc: Suman Anna, linux-remoteproc, devicetree, linux-kernel,
	Kishon Vijay Abraham I

Series adds AM62x specific compatible string to enable PRUSS-M in
AM62x SoCs.

Kishon Vijay Abraham I (2):
  dt-bindings: remoteproc: pru: Update bindings for K3 AM62x SoCs
  remoteproc: pru: Add support for various PRU cores on K3 AM62x SoCs

 Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
 drivers/remoteproc/pru_rproc.c                                 | 1 +
 2 files changed, 2 insertions(+)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM62x SoCs
  2022-04-27  8:35 [PATCH 0/2] remoteproc: pru: Enable PRU cores on K3 AM62x SoCs Kishon Vijay Abraham I
@ 2022-04-27  8:35 ` Kishon Vijay Abraham I
  2022-04-28  6:18   ` Krzysztof Kozlowski
  2022-04-27  8:35 ` [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on " Kishon Vijay Abraham I
  1 sibling, 1 reply; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2022-04-27  8:35 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski
  Cc: Suman Anna, linux-remoteproc, devicetree, linux-kernel,
	Kishon Vijay Abraham I

Update the PRU remoteproc bindings for the PRU cores on AM62x SoCs.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
index d7c3a78e37e6..e351550b012c 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
@@ -47,6 +47,7 @@ properties:
       - ti,j721e-pru    # for PRUs in K3 J721E SoC family
       - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
       - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
+      - ti,am625-pru    # for PRUs in K3 AM62x SoC family
 
   reg:
     items:
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on K3 AM62x SoCs
  2022-04-27  8:35 [PATCH 0/2] remoteproc: pru: Enable PRU cores on K3 AM62x SoCs Kishon Vijay Abraham I
  2022-04-27  8:35 ` [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for " Kishon Vijay Abraham I
@ 2022-04-27  8:35 ` Kishon Vijay Abraham I
  1 sibling, 0 replies; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2022-04-27  8:35 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski
  Cc: Suman Anna, linux-remoteproc, devicetree, linux-kernel,
	Kishon Vijay Abraham I

The K3 AM62x family of SoC has one PRUSS-M instance and it has two
Programmable Real-Time Units (PRU0 and PRU1). This does not support
Industrial Communications Subsystem features like Ethernet.

Enhance the existing PRU remoteproc driver to support the PRU cores
by using specific compatibles. The initial names for the firmware
images for each PRU core are retrieved from DT nodes, and can be adjusted
through sysfs if required.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/remoteproc/pru_rproc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index 1777a01fa84e..128bf9912f2c 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -897,6 +897,7 @@ static const struct of_device_id pru_rproc_match[] = {
 	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
 	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
 	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
+	{ .compatible = "ti,am625-pru",		.data = &k3_pru_data },
 	{},
 };
 MODULE_DEVICE_TABLE(of, pru_rproc_match);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM62x SoCs
  2022-04-27  8:35 ` [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for " Kishon Vijay Abraham I
@ 2022-04-28  6:18   ` Krzysztof Kozlowski
  2022-05-16 12:35     ` Kishon Vijay Abraham I
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-28  6:18 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Bjorn Andersson, Mathieu Poirier,
	Rob Herring, Krzysztof Kozlowski
  Cc: Suman Anna, linux-remoteproc, devicetree, linux-kernel

On 27/04/2022 10:35, Kishon Vijay Abraham I wrote:
> Update the PRU remoteproc bindings for the PRU cores on AM62x SoCs.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> index d7c3a78e37e6..e351550b012c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> @@ -47,6 +47,7 @@ properties:
>        - ti,j721e-pru    # for PRUs in K3 J721E SoC family
>        - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
>        - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
> +      - ti,am625-pru    # for PRUs in K3 AM62x SoC family

Looks like out of order.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM62x SoCs
  2022-04-28  6:18   ` Krzysztof Kozlowski
@ 2022-05-16 12:35     ` Kishon Vijay Abraham I
  2022-05-16 15:17       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2022-05-16 12:35 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Bjorn Andersson, Mathieu Poirier,
	Rob Herring, Krzysztof Kozlowski
  Cc: Suman Anna, linux-remoteproc, devicetree, linux-kernel

Hi Krzysztof,

On 28/04/22 11:48, Krzysztof Kozlowski wrote:
> On 27/04/2022 10:35, Kishon Vijay Abraham I wrote:
>> Update the PRU remoteproc bindings for the PRU cores on AM62x SoCs.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>>  Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>> index d7c3a78e37e6..e351550b012c 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>> @@ -47,6 +47,7 @@ properties:
>>        - ti,j721e-pru    # for PRUs in K3 J721E SoC family
>>        - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
>>        - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
>> +      - ti,am625-pru    # for PRUs in K3 AM62x SoC family
> 
> Looks like out of order.

yes, this is out of sync with the existing format binding. I'll send a
patch fixing it.

Thanks,
Kishon

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM62x SoCs
  2022-05-16 12:35     ` Kishon Vijay Abraham I
@ 2022-05-16 15:17       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-16 15:17 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Bjorn Andersson, Mathieu Poirier,
	Rob Herring, Krzysztof Kozlowski
  Cc: Suman Anna, linux-remoteproc, devicetree, linux-kernel

On 16/05/2022 14:35, Kishon Vijay Abraham I wrote:
> Hi Krzysztof,
> 
> On 28/04/22 11:48, Krzysztof Kozlowski wrote:
>> On 27/04/2022 10:35, Kishon Vijay Abraham I wrote:
>>> Update the PRU remoteproc bindings for the PRU cores on AM62x SoCs.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>> ---
>>>  Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>>> index d7c3a78e37e6..e351550b012c 100644
>>> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>>> @@ -47,6 +47,7 @@ properties:
>>>        - ti,j721e-pru    # for PRUs in K3 J721E SoC family
>>>        - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
>>>        - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
>>> +      - ti,am625-pru    # for PRUs in K3 AM62x SoC family
>>
>> Looks like out of order.
> 
> yes, this is out of sync with the existing format binding. I'll send a
> patch fixing it.

I meant, you introduce it out-of-order. So this patch should be modified
and new compatible added in some better place.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-16 15:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27  8:35 [PATCH 0/2] remoteproc: pru: Enable PRU cores on K3 AM62x SoCs Kishon Vijay Abraham I
2022-04-27  8:35 ` [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for " Kishon Vijay Abraham I
2022-04-28  6:18   ` Krzysztof Kozlowski
2022-05-16 12:35     ` Kishon Vijay Abraham I
2022-05-16 15:17       ` Krzysztof Kozlowski
2022-04-27  8:35 ` [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on " Kishon Vijay Abraham I

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).