From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA48AC433F4 for ; Wed, 19 Sep 2018 10:09:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61DC12150D for ; Wed, 19 Sep 2018 10:09:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61DC12150D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=windriver.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731302AbeISPqy (ORCPT ); Wed, 19 Sep 2018 11:46:54 -0400 Received: from mail.windriver.com ([147.11.1.11]:36733 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728008AbeISPqy (ORCPT ); Wed, 19 Sep 2018 11:46:54 -0400 Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id w8JA9bE2018832 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 19 Sep 2018 03:09:37 -0700 (PDT) Received: from [128.224.162.216] (128.224.162.216) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 19 Sep 2018 03:09:36 -0700 Subject: Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line To: Sergey Senozhatsky , , CC: , References: <1537291068-443145-1-git-send-email-zhe.he@windriver.com> <20180919015030.GA423@jagdpanzerIV> <6c354803-5341-7237-9ee3-7882252c7483@windriver.com> <20180919064418.GC792@jagdpanzerIV> From: He Zhe Message-ID: Date: Wed, 19 Sep 2018 18:09:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180919064418.GC792@jagdpanzerIV> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [128.224.162.216] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018年09月19日 14:44, Sergey Senozhatsky wrote: > On (09/19/18 10:27), He Zhe wrote: >> On 2018年09月19日 09:50, Sergey Senozhatsky wrote: >>> On (09/19/18 01:17), zhe.he@windriver.com wrote: >>>> @@ -1048,7 +1048,14 @@ static void __init log_buf_len_update(unsigned size) >>>> /* save requested log_buf_len since it's too early to process it */ >>>> static int __init log_buf_len_setup(char *str) >>>> { >>>> - unsigned size = memparse(str, &str); >>>> + unsigned size; >>> unsigned int size; >> This is in v1 but then Steven suggested that it should be split out >> and only keep the pure fix part here. > JFI > > Seems there are more patches like this. I found this one in MM list: > lkml.kernel.org/r/1537284788-428784-1-git-send-email-zhe.he@windriver.com > > Andrew's response: > lkml.kernel.org/r/20180918141917.2cb16b01c122dbe1ead2f657@linux-foundation.org I just replied. Let's see what Andrew would say. https://lore.kernel.org/lkml/1c32c1d2-a54a-30f7-1afb-ad6d3282f54a@windriver.com/ Thanks, Zhe > > -ss >