From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F9DC4332E for ; Wed, 27 Jan 2021 17:58:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D694A64D9A for ; Wed, 27 Jan 2021 17:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344273AbhA0R54 (ORCPT ); Wed, 27 Jan 2021 12:57:56 -0500 Received: from linux.microsoft.com ([13.77.154.182]:51756 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233602AbhA0R5g (ORCPT ); Wed, 27 Jan 2021 12:57:36 -0500 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 2122320B7192; Wed, 27 Jan 2021 09:56:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2122320B7192 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1611770214; bh=vvGJ3Dw+P3cv0U4VoHgL/alIB6MLatAQqWQeXHRPyf8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=CMvoZn/y9uX2BE+OvTUHQY580cu1ambGmPIPDRbaJIGKZMJ6YhIkHXDfgZcxExCuz Y4TEVyk1LhecePWTsRk2No/AJ+BCXh+Oj/mhdv526SghnwMzyzjuSpVWvT+boP9LTp du3iLImTUK2O4SNWCPna1xtTn1T8OeHEXsaBMnkg= Subject: Re: [PATCH v15 10/10] arm64: Add IMA log information in kimage used for kexec To: Will Deacon Cc: zohar@linux.ibm.com, bauerman@linux.ibm.com, robh@kernel.org, takahiro.akashi@linaro.org, gregkh@linuxfoundation.org, catalin.marinas@arm.com, mpe@ellerman.id.au, james.morse@arm.com, sashal@kernel.org, benh@kernel.crashing.org, paulus@samba.org, frowand.list@gmail.com, vincenzo.frascino@arm.com, mark.rutland@arm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, pasha.tatashin@soleen.com, allison@lohutok.net, masahiroy@kernel.org, bhsharma@redhat.com, mbrugger@suse.com, hsinyi@chromium.org, tao.li@vivo.com, christophe.leroy@c-s.fr, prsriva@linux.microsoft.com, balajib@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <20210115173017.30617-1-nramas@linux.microsoft.com> <20210115173017.30617-11-nramas@linux.microsoft.com> <20210127165424.GB358@willie-the-truck> From: Lakshmi Ramasubramanian Message-ID: Date: Wed, 27 Jan 2021 09:56:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210127165424.GB358@willie-the-truck> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/27/21 8:54 AM, Will Deacon wrote: Hi Will, > On Fri, Jan 15, 2021 at 09:30:17AM -0800, Lakshmi Ramasubramanian wrote: >> Address and size of the buffer containing the IMA measurement log need >> to be passed from the current kernel to the next kernel on kexec. >> >> Add address and size fields to "struct kimage_arch" for ARM64 platform >> to hold the address and size of the IMA measurement log buffer. >> >> Update CONFIG_KEXEC_FILE to select CONFIG_HAVE_IMA_KEXEC, if CONFIG_IMA >> is enabled, to indicate that the IMA measurement log information is >> present in the device tree for ARM64. >> >> Co-developed-by: Prakhar Srivastava >> Signed-off-by: Prakhar Srivastava >> Signed-off-by: Lakshmi Ramasubramanian >> Reviewed-by: Thiago Jung Bauermann >> --- >> arch/arm64/Kconfig | 1 + >> arch/arm64/include/asm/kexec.h | 5 +++++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 1d466addb078..ea7f7fe3dccd 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -1094,6 +1094,7 @@ config KEXEC >> config KEXEC_FILE >> bool "kexec file based system call" >> select KEXEC_CORE >> + select HAVE_IMA_KEXEC if IMA >> help >> This is new version of kexec system call. This system call is >> file based and takes file descriptors as system call argument >> diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h >> index d24b527e8c00..2bd19ccb6c43 100644 >> --- a/arch/arm64/include/asm/kexec.h >> +++ b/arch/arm64/include/asm/kexec.h >> @@ -100,6 +100,11 @@ struct kimage_arch { >> void *elf_headers; >> unsigned long elf_headers_mem; >> unsigned long elf_headers_sz; >> + >> +#ifdef CONFIG_IMA_KEXEC >> + phys_addr_t ima_buffer_addr; >> + size_t ima_buffer_size; >> +#endif > > Why do these need to be in the arch structure instead of 'struct kimage'? > Currently, only powerpc and, with this patch set, arm64 have support for carrying forward IMA measurement list across kexec system call. The above fields are used for tracking IMA measurement list. Do you see a reason to move these fields to "struct kimage"? thanks, -lakshmi