From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEF82134A3; Thu, 25 Jan 2024 23:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706224390; cv=none; b=YMpLmfn61qZAQTJ1ynyy7N92jEYhljRKqEVWrDV6t5Cw6BKtZ+AXkWOtzIU5OP1EsqZkHYYjVXmMcaGfhfN7axli30w14eVPbfMeZYQrO5EQ6LTvstAeToEQgDDACNaJNE1nZtM+4zvONN/TuhTR+milrQmr/97EBMzde++VgZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706224390; c=relaxed/simple; bh=9flTA40nrohKjnR1u2q4ufge3KYUiV6E/UDx3w19aNA=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=DNEdWfc3CEodBWd4srlILYiTF+pjPHDtCMjb4uzKpyMqfBY5ooXysWzYioJ4qRYUGDnBbbcNdXaX3S82eFeFYhbYppHFTcpXeBPo8ecwtmtDrJpKeKSj4UuhxcVbC3/Uwn62URQtIzT6a3cD4yL7mkkxTfHjjclBmYkkYIjl/fA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=oQ9PeWRp; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="oQ9PeWRp" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1706224385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPLAItx+quR8qx4bS8DZbs9AeDwCziiqDgH23b0i5fE=; b=oQ9PeWRpZTirjz9bTW4hltMyh5cfkAEcXosHgnbSj01VRcBdhrbfktaj2VqawtHPjlwtoX n0MjVrItA8DbSPUMt2s/xcvd4nR0BTD2Lh/lbNLe8CJQJLf5nTrIZUDopUNgp2RvPOwh68 6F6etuRRi7GchXscC6E61psCHUF0J88CYLcu4fvpVtPcyiSxEQ6m9qUXUzf/IviR7u4Gm2 ufzTlbs5PtiTvSRydUvunEGTIJYb15HWMwpTGkE/StCFn0E0tPjFx70LxLeMvhTKq47sgQ WW3BByk26uVaz7buFpTPq0DdUrg35l/hCsknPe1V6JGl10enLHS4ITrRrvCIZA== Date: Fri, 26 Jan 2024 00:13:05 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] arm64: dts: rockchip: enable temperature driven fan control on Rock 5B In-Reply-To: <20240125-rk-dts-additions-v1-3-5879275db36f@gmail.com> References: <20240125-rk-dts-additions-v1-0-5879275db36f@gmail.com> <20240125-rk-dts-additions-v1-3-5879275db36f@gmail.com> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Hello Alexey, On 2024-01-24 21:30, Alexey Charkov wrote: > This enables thermal monitoring on Radxa Rock 5B and links the PWM > fan as an active cooling device managed automatically by the thermal > subsystem, with a target SoC temperature of 55C > > Signed-off-by: Alexey Charkov > --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 25 > ++++++++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > index 9b7bf6cec8bd..c4c94e0b6163 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > @@ -52,7 +52,7 @@ led_rgb_b { > > fan: pwm-fan { > compatible = "pwm-fan"; > - cooling-levels = <0 95 145 195 255>; > + cooling-levels = <0 120 150 180 210 240 255>; > fan-supply = <&vcc5v0_sys>; > pwms = <&pwm1 0 50000 0>; > #cooling-cells = <2>; > @@ -180,6 +180,25 @@ &cpu_l3 { > cpu-supply = <&vdd_cpu_lit_s0>; > }; > > +&package_thermal { > + polling-delay = <1000>; > + > + trips { > + package_fan: package-fan { > + temperature = <55000>; > + hysteresis = <2000>; > + type = "active"; > + }; > + }; > + > + cooling-maps { > + map-fan { > + trip = <&package_fan>; > + cooling-device = <&fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > +}; It should be better to have two new trips and two new cooling maps defined, instead of having just one trip/map pair, like this: &package_thermal { polling-delay = <1000>; trips { package_warm: package-warm { temperature = <55000>; hysteresis = <2000>; type = "active"; }; package_hot: package-hot { temperature = <65000>; hysteresis = <2000>; type = "active"; }; }; cooling-maps { mapX { trip = <&package_warm>; cooling-device = <&fan THERMAL_NO_LIMIT 1>; }; mapY { trip = <&package_hot>; cooling-device = <&fan 2 THERMAL_NO_LIMIT>; }; }; }; The idea behind this approach is to keep the fan spinning at the lowest available speed until the package temperature reaches the second trip's temperature level, at which point the fan starts ramping up. An approach like this is already employed by the Pine64 RockPro64 SBC. This way, we'll be doing our best to keep the fan noise down; of course, it will depend on the particular heatsink and fan combo how long the fan can be kept at the lowest speed, but we should aim at supporting as many different cooling setups as possible, and as well as possible, out of the box and with no additional tweaking required. Please notice "mapX" and "mapY" as the names of the additional cooling maps, where X and Y are simply the next lowest available indices, which is pretty much the usual way to name the additional cooling maps. > &i2c0 { > pinctrl-names = "default"; > pinctrl-0 = <&i2c0m2_xfer>; > @@ -738,6 +757,10 @@ regulator-state-mem { > }; > }; > > +&tsadc { > + status = "okay"; > +}; > + > &uart2 { > pinctrl-0 = <&uart2m0_xfer>; > status = "okay";