From: David Woodhouse <dwmw2@infradead.org>
To: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@fb.com>, James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Keith Busch <keith.busch@intel.com>,
Maximilian Heyne <mheyne@amazon.de>, Amit Shah <aams@amazon.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 0/2] Adding per-controller timeout support to nvme
Date: Thu, 25 Apr 2019 07:45:31 +0200 [thread overview]
Message-ID: <df0c4a9cce5928fdc8ba3a1858e4c6611edb4474.camel@infradead.org> (raw)
In-Reply-To: <db034829-7140-1374-0132-7d27240b8b3b@grimberg.me>
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On Wed, 2019-04-24 at 13:58 -0700, Sagi Grimberg wrote:
> > It isn't that the media is slow; the max timeout is based on the SLA
> > for certain classes of "fabric" outages. Linux copes *really* badly
> > with I/O errors, and if we can make the timeout last long enough to
> > cover the switch restart worst case, then users are a lot happier.
>
> Well, what is usually done to handle fabric outages is having multiple
> paths to the storage device, not sure if that is applicable for you or
> not...
Yeah, that turns out to be impractical in this case.
> What do you mean by "Linux copes *really* badly with I/O errors"? What
> can be done better?
There's not a lot that can be done here in the short term. If file
systems get errors on certain I/O, then graceful recovery would be
complicated to achieve.
Better for the I/O timeout to be set higher than the known worst case
time for successful completion.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]
prev parent reply other threads:[~2019-04-25 5:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 12:35 [PATCH v2 0/2] Adding per-controller timeout support to nvme Maximilian Heyne
2019-04-03 12:35 ` [PATCH v2 1/2] nvme: add per-controller io and admin timeouts Maximilian Heyne
2019-04-03 12:35 ` [PATCH v2 2/2] nvme: add sysfs controls for " Maximilian Heyne
2019-04-09 10:23 ` Christoph Hellwig
2019-04-24 16:55 ` [PATCH v2 0/2] Adding per-controller timeout support to nvme Sagi Grimberg
2019-04-24 20:07 ` Keith Busch
2019-04-24 20:30 ` David Woodhouse
2019-04-24 20:44 ` Keith Busch
2019-04-24 20:58 ` Sagi Grimberg
2019-04-25 5:45 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df0c4a9cce5928fdc8ba3a1858e4c6611edb4474.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=aams@amazon.de \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mheyne@amazon.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).