From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: min.guo@mediatek.com, Bin Liu <b-liu@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Matthias Brugger <matthias.bgg@gmail.com>,
chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3] usb: musb: remove unused variable 'devctl'
Date: Tue, 24 Nov 2020 14:45:01 +0300 [thread overview]
Message-ID: <df11df93-f2ab-157c-22ea-cb8b8a0d9969@gmail.com> (raw)
In-Reply-To: <c2f3f643-8514-5c4a-dd52-7abc8a6dc501@gmail.com>
On 11/24/20 12:13 PM, Sergei Shtylyov wrote:
[...]
>> From: Min Guo <min.guo@mediatek.com>
>>
>> Remove unused 'devctl' variable to fix compile warnings:
>>
>> drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq':
>> drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set
>> but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Min Guo <min.guo@mediatek.com>
>> ---
>> changes in v3
>> suggested by Greg Kroah-Hartman:
>> Add a comment.
>>
>> changes in v2
>> suggested by Alan Stern:
>> Add void before musb_read to indicate that the register MUSB_DEVCTL
>> was intended to be read and discarded.
>> ---
>> drivers/usb/musb/musbhsdma.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
>> index 0aacfc8be5a1..2a345b4ad015 100644
>> --- a/drivers/usb/musb/musbhsdma.c
>> +++ b/drivers/usb/musb/musbhsdma.c
> [...]
>> @@ -336,7 +334,11 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
>> < musb_channel->len) ?
>> "=> reconfig 0" : "=> complete");
>> - devctl = musb_readb(mbase, MUSB_DEVCTL);
>> + /*
>> + * Some hardware may need to read the
>> + * MUSB_DEVCTL register once to take effect.
>> + */
>> + (void)musb_readb(mbase, MUSB_DEVCTL);
>
> Hm, forcibly reading DevCtl in the DMA driver... sounds quite nonsensically. Lemme take a look...
Indeed, prior to commit c418fd6c01fbc5516a2cd1eaf1df1ec86869028a ("usb: gadget: musb: fix short
isoc packets with inventra dma") the DevCtl read was done in order to check the DevCtl.HostMode bit --
this test was removed but the DevCtl read was left intact... so my vote goes for deleting both the
read and the variable...
> [...]
MBR, Sergei
next prev parent reply other threads:[~2020-11-24 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 8:49 [PATCH v3] usb: musb: remove unused variable 'devctl' min.guo
2020-11-24 9:13 ` Sergei Shtylyov
2020-11-24 11:45 ` Sergei Shtylyov [this message]
2020-12-10 15:01 ` Greg Kroah-Hartman
2020-12-10 17:33 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df11df93-f2ab-157c-22ea-cb8b8a0d9969@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=b-liu@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).