From: "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
To: "joro@8bytes.org" <joro@8bytes.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
"Singh, Brijesh" <brijesh.singh@amd.com>
Subject: Re: [PATCH] iommu/amd: Fix IOMMU page flush when detach all devices from a domain
Date: Wed, 16 Jan 2019 14:40:59 +0000 [thread overview]
Message-ID: <df209299-8fd1-189c-9c44-b398cf790d1a@amd.com> (raw)
In-Reply-To: <20190116132648.i5n3hz3k7d2wxbrx@8bytes.org>
Joerg,
On 1/16/19 8:26 PM, joro@8bytes.org wrote:
> How about the attached diff? If
> I understand the problem correctly, it should fix the problem more
> reliably.
>
> Thanks,
>
> Joerg
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index 87ba23a75b38..dc1e2a8a19d7 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -1991,25 +1991,36 @@ static void do_attach(struct iommu_dev_data *dev_data,
>
> static void do_detach(struct iommu_dev_data *dev_data)
> {
> + struct protection_domain *domain = dev_data->domain;
> struct amd_iommu *iommu;
> u16 alias;
>
> iommu = amd_iommu_rlookup_table[dev_data->devid];
> alias = dev_data->alias;
>
> - /* decrease reference counters */
> - dev_data->domain->dev_iommu[iommu->index] -= 1;
> - dev_data->domain->dev_cnt -= 1;
> -
> /* Update data structures */
> dev_data->domain = NULL;
> list_del(&dev_data->list);
> - clear_dte_entry(dev_data->devid);
> - if (alias != dev_data->devid)
> - clear_dte_entry(alias);
>
> + clear_dte_entry(dev_data->devid);
> /* Flush the DTE entry */
> device_flush_dte(dev_data);
> +
> + if (alias != dev_data->devid) {
> + clear_dte_entry(alias);
> + /* Flush the Alias DTE entry */
> + device_flush_dte(alias);
> + }
> +
Actually, device_flush_dte(alias) should be needed regardless of this patch.
Are you planning to add this?
Regards,
Suravee
next prev parent reply other threads:[~2019-01-16 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 4:16 [PATCH] iommu/amd: Fix IOMMU page flush when detach all devices from a domain Suthikulpanit, Suravee
2019-01-16 13:26 ` joro
2019-01-16 14:08 ` Suthikulpanit, Suravee
2019-01-16 17:08 ` joro
2019-01-17 8:44 ` Suthikulpanit, Suravee
2019-01-17 11:48 ` Suthikulpanit, Suravee
2019-01-22 10:44 ` joro
2019-01-22 15:53 ` Suthikulpanit, Suravee
2019-01-23 7:56 ` joro
2019-01-24 3:25 ` Suthikulpanit, Suravee
2019-01-24 8:04 ` joro
2019-01-16 14:40 ` Suthikulpanit, Suravee [this message]
2019-01-16 17:09 ` joro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df209299-8fd1-189c-9c44-b398cf790d1a@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).