From: "wangyanan (Y)" <wangyanan55@huawei.com>
To: Marc Zyngier <maz@kernel.org>
Cc: James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Eric Auger <eric.auger@redhat.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<kvmarm@lists.cs.columbia.edu>, <linux-kernel@vger.kernel.org>,
<yuzenghui@huawei.com>, <wanghaibin.wang@huawei.com>
Subject: Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files
Date: Tue, 15 Jun 2021 18:05:04 +0800 [thread overview]
Message-ID: <df4aa056-e15b-ae5f-ace1-1f6e5561dfd8@huawei.com> (raw)
In-Reply-To: <87o8c7ihlf.wl-maz@kernel.org>
On 2021/6/15 17:48, Marc Zyngier wrote:
> On Tue, 15 Jun 2021 04:50:19 +0100,
> Yanan Wang <wangyanan55@huawei.com> wrote:
>> These fixes introduce no functional change but just adjustment about
>> coding style issues for ARM64 vgic code. They mainly include identation
>> fix of function parameters/arguments, identation fix of structure
>> initialization, identation fix of comment, also the deletion of some
>> superfluous space lines.
> Please don't. This sort of patches bring little value, and make the
> backporting of important fixes more difficult because of pointless
> context change.
Oh, this is an point that I didn't notice but indeed worths considering.
> Fixing these cosmetic details is fine when you are modifying the
> code. But as a standalone patch, this brings more pain than benefit.
Ok, I will just drop this stuff. Sorry for the noise.
Thanks,
Yanan
> Thanks,
>
> M.
>
prev parent reply other threads:[~2021-06-15 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 3:50 [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files Yanan Wang
2021-06-15 9:48 ` Marc Zyngier
2021-06-15 10:05 ` wangyanan (Y) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df4aa056-e15b-ae5f-ace1-1f6e5561dfd8@huawei.com \
--to=wangyanan55@huawei.com \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=eric.auger@redhat.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=wanghaibin.wang@huawei.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).