From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E3CC07E9A for ; Wed, 14 Jul 2021 13:26:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A01A2601FF for ; Wed, 14 Jul 2021 13:26:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232007AbhGNN3Z (ORCPT ); Wed, 14 Jul 2021 09:29:25 -0400 Received: from ofcsgdbm.dwd.de ([141.38.3.245]:47123 "EHLO ofcsgdbm.dwd.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231521AbhGNN3U (ORCPT ); Wed, 14 Jul 2021 09:29:20 -0400 Received: from localhost (localhost [127.0.0.1]) by ofcsg2dn1.dwd.de (Postfix) with ESMTP id 4GPyvR4h0Wz1yfK for ; Wed, 14 Jul 2021 13:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=dwd.de; h= content-type:content-type:mime-version:references:message-id :in-reply-to:subject:subject:from:from:date:date:received :received:received:received:received:received:received:received; s=dwd-csg20210107; t=1626269187; x=1627478788; bh=hdFT0cqBNvrij zVT0ctruTOy0UZY4W/lUJFZwHtlokU=; b=3Q98dAf8PLCHUPOeNhMYzlCOkvAtJ Ty0vS25W7kqM/hvEmld7zCAMFTQrrKQpGOmkARu4pIAMki5DITDXg8+jGXhWTRX0 py983iWPrthzusFdG7XUv1txywZc5+eFWVrw1a3gOYE4TBsykNsg2cRTJ2/1tUm+ A9BnDLFijPyq4JZxcox+q3Rm33xqkKQDV3Sg8exJYa3SJgSJA6fE4t94iH1L1gPy ff4irGwjQWwsM4UAk97KHBJOmNp2cub8tf0AglpBi/Fk/VdVrW7eUVCXRaqK/WMU XU3eQt3WZpQWKcFcB4ufjDg1XpcDmZEer+rxDCIDunv4uSk7P/G+jmhhw== X-Virus-Scanned: by amavisd-new at csg.dwd.de Received: from ofcsg2ctev2.dwd.de ([172.30.232.68]) by localhost (ofcsg2dn1.dwd.de [172.30.232.24]) (amavisd-new, port 10024) with ESMTP id yQ3Gw1iZVhGv for ; Wed, 14 Jul 2021 13:26:27 +0000 (UTC) Received: from ofcsg2ctev2.dwd.de (unknown [127.0.0.1]) by DDEI (Postfix) with ESMTP id E411B5E3C84 for ; Wed, 14 Jul 2021 13:26:25 +0000 (UTC) Received: from ofcsg2ctev2.dwd.de (unknown [127.0.0.1]) by DDEI (Postfix) with ESMTP id D6B105E1D70 for ; Wed, 14 Jul 2021 13:26:25 +0000 (UTC) X-DDEI-TLS-USAGE: Unused Received: from ofcsgdbm.dwd.de (unknown [172.30.232.24]) by ofcsg2ctev2.dwd.de (Postfix) with ESMTP for ; Wed, 14 Jul 2021 13:26:25 +0000 (UTC) Received: from ofcsgdbm.dwd.de by localhost (Postfix XFORWARD proxy); Wed, 14 Jul 2021 13:26:27 -0000 Received: from ofcsg2dvf1.dwd.de (ofcsg2dvf1.dwd.de [172.30.232.10]) by ofcsg2dn1.dwd.de (Postfix) with ESMTPS id 4GPyvR2QS8z1xPB; Wed, 14 Jul 2021 13:26:27 +0000 (UTC) Received: from ofmailhub.dwd.de (oflxs16.dwd.de [141.38.39.208]) by ofcsg2dvf1.dwd.de with ESMTP id 16EDQQvF032493-16EDQQvG032493; Wed, 14 Jul 2021 13:26:26 GMT Received: from praktifix.dwd.de (praktifix.dwd.de [141.38.44.46]) by ofmailhub.dwd.de (Postfix) with ESMTP id BE000453F5; Wed, 14 Jul 2021 13:26:26 +0000 (UTC) Date: Wed, 14 Jul 2021 13:26:26 +0000 (GMT) From: Holger Kiehl To: Greg Kroah-Hartman , Jan Kara cc: linux-kernel , torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, stable@vger.kernel.org Subject: Re: [PATCH 5.13 000/800] 5.13.2-rc1 review In-Reply-To: <50fb4713-6b5d-b5e0-786a-6ece57896d2f@praktifix.dwd.de> Message-ID: References: <20210712060912.995381202@linuxfoundation.org> <68b6051-09c-9dc8-4b52-c4e766fee5@praktifix.dwd.de> <50fb4713-6b5d-b5e0-786a-6ece57896d2f@praktifix.dwd.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-FE-Policy-ID: 2:2:1:SYSTEM X-TMASE-Version: DDEI-5.1-8.6.1018-26280.007 X-TMASE-Result: 10--20.925600-10.000000 X-TMASE-MatchedRID: x2HXvaraFomWfDtBOz4q28bYuTb6+cQg69aS+7/zbj/mNRhvDVinv2Kp MJoimBcbPsj5qjS+dCEYwvDSTCG2BJQlTsRs6bL83nHtGkYl/VpF/jSlPtma/r0/f33kf9Gljn9 2T7igP2sXndhpsXecxygywW45LfL0yFuWu3nxO+19j6Il8VAHF8ZU3kmz9C/H3pxmYneHU6t/cL JHsj+DkZhk/6bphJLMKISk8WdGcXCHbsX/GOLqdgPZZctd3P4BuqgVqRoQsiB7lDzh8Z+EhhBmt oCUanEvwgx24xjlvojzX5siSEObomsc2OVQ/NyCfid4LSHtIANuWkE39mLwR2zpNYa+Tlcne/cQ kmt0G7GVIsnYOY5w/uF45apSJW4bV6HcTxi1U3IqkSeDPauzryIk3dpe5X+hy5JfHvVu9Itvxt6 yFJGkPy7TvubsyJqlq4m5Bec/+bTecSkNT7l/2Tn/wcdfjLjCp5HLLTy++LOKpw8ALShsZoIV24 CuYj50/sXPK0ncsYCD2kmNFYh3E4R9x+rbFqRWhL9NX2TqmkAApu/OILCbuFGeC58QTjRVY2iR7 K8WcszjMF8ggjW87E7NMOR+KVhPkfRhdidsajP+xOhjarOnHt0H8LFZNFG7/nnwJ52QYi+pygCG KFPC+BeYl5uS2QAg X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0 X-TMASE-INERTIA: 0-0;;;; X-DDEI-PROCESSED-RESULT: Safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Jul 2021, Holger Kiehl wrote: > On Wed, 14 Jul 2021, Greg Kroah-Hartman wrote: > > > On Wed, Jul 14, 2021 at 05:39:43AM +0000, Holger Kiehl wrote: > > > Hello, > > > > > > On Mon, 12 Jul 2021, Greg Kroah-Hartman wrote: > > > > > > > This is the start of the stable review cycle for the 5.13.2 release. > > > > There are 800 patches in this series, all will be posted as a response > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > > > Responses should be made by Wed, 14 Jul 2021 06:02:46 +0000. > > > > Anything received after that time might be too late. > > > > > > > With this my system no longer boots: > > > > > > [ OK ] Reached target Swap. > > > [ 75.213852] NMI watchdog: Watchdog detected hard LOCKUP on cpu 0 > > > [ 75.213926] NMI watchdog: Watchdog detected hard LOCKUP on cpu 2 > > > [ 75.213962] NMI watchdog: Watchdog detected hard LOCKUP on cpu 4 > > > [FAILED] Failed to start Wait for udev To Complete Device Initialization. > > > See 'systemctl status systemd-udev-settle.service' for details. > > > Starting Activation of DM RAID sets... > > > [ ] (1 of 2) A start job is running for Activation of DM RAID sets (..min ..s / no limit) > > > [ ] (2 of 2) A start job is running for Monitoring of LVM2 mirrors, snapshots etc. using dmeventd or progress polling (..min ..s / no limit) > > > > > > System is a Fedora 34 with all updates applied. Two other similar > > > systems with AMD CPUs (Ryzen 4750G + 3400G) this does not happen > > > and boots fine. The system where it does not boot has an Intel > > > Xeon E3-1285L v4 CPU. All of them use a dm_crypt root filesystem. > > > > > > Any idea which patch I should drop to see if it boots again. I already > > > dropped > > > > > > [PATCH 5.13 743/800] ASoC: Intel: sof_sdw: add quirk support for Brya and BT-offload > > > > > > and I just see that this one should also be dropped: > > > > > > [PATCH 5.13 768/800] hugetlb: address ref count racing in prep_compound_gigantic_page > > > > > > Will still need to test this. > > > > Can you run 'git bisect' to see what commit causes the problem? > > > Yes, will try to do that. I think it will take some time ... > With the help of Pavel Machek and Jiri Slaby I was able 'git bisect' this to: yoda:/usr/src/kernels/linux-5.13.y# git bisect good a483f513670541227e6a31ac7141826b8c785842 is the first bad commit commit a483f513670541227e6a31ac7141826b8c785842 Author: Jan Kara Date: Wed Jun 23 11:36:33 2021 +0200 bfq: Remove merged request already in bfq_requests_merged() [ Upstream commit a921c655f2033dd1ce1379128efe881dda23ea37 ] Currently, bfq does very little in bfq_requests_merged() and handles all the request cleanup in bfq_finish_requeue_request() called from blk_mq_free_request(). That is currently safe only because blk_mq_free_request() is called shortly after bfq_requests_merged() while bfqd->lock is still held. However to fix a lock inversion between bfqd->lock and ioc->lock, we need to call blk_mq_free_request() after dropping bfqd->lock. That would mean that already merged request could be seen by other processes inside bfq queues and possibly dispatched to the device which is wrong. So move cleanup of the request from bfq_finish_requeue_request() to bfq_requests_merged(). Acked-by: Paolo Valente Signed-off-by: Jan Kara Link: https://lore.kernel.org/r/20210623093634.27879-2-jack@suse.cz Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin block/bfq-iosched.c | 41 +++++++++++++---------------------------- 1 file changed, 13 insertions(+), 28 deletions(-) Holger