From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Andy Yan <andy.yan@rock-chips.com>, sre@kernel.org
Cc: matthias.bgg@gmail.com, dbaryshkov@gmail.com, richard@nod.at,
alexandre.belloni@free-electrons.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, dwmw2@infradead.org,
nicolas.ferre@atmel.com
Subject: Re: [PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM
Date: Fri, 12 Aug 2016 14:48:40 +0200 [thread overview]
Message-ID: <df657519-da7b-dbf3-1096-54253cb289c1@samsung.com> (raw)
In-Reply-To: <1470996110-8550-1-git-send-email-andy.yan@rock-chips.com>
On 08/12/2016 12:01 PM, Andy Yan wrote:
> commit 4fcd504edbf7 ("power: reset: add reboot mode driver") uses api from
> syscon, and syscon uses ioremap/iounmap which depends on HAS_IOMEM, so
> let's depend on MFD_SYSCON instead of selecting it directly to avoid the
> um-allyesconfig like build error on archs that without iomem:
>
> drivers/mfd/syscon.c: In function 'of_syscon_register':
> drivers/mfd/syscon.c:67:9: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
> base = ioremap(res.start, resource_size(&res));
> ^
> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> base = ioremap(res.start, resource_size(&res));
> ^
> drivers/mfd/syscon.c:109:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
> iounmap(base);
> ^
>
> Reported-by: Kbuild test robot <fengguang.wu@intel.com>
> Fixes: 4fcd504edbf7("power: reset: add reboot mode driver")
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> ---
>
> Changes in v1:
> - let this driver depend on MFD_SYSCON
> - add Reported-by tag, which suggested by Krzysztof Kozlowski
> - add Fixes tag, which suggested by Matthias Brugger
>
> drivers/power/reset/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-08-12 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 10:01 [PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM Andy Yan
2016-08-12 12:48 ` Krzysztof Kozlowski [this message]
2016-08-16 10:55 ` Andy Yan
2016-08-16 22:07 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df657519-da7b-dbf3-1096-54253cb289c1@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andy.yan@rock-chips.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nicolas.ferre@atmel.com \
--cc=richard@nod.at \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).