From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756608AbdDPRsq (ORCPT ); Sun, 16 Apr 2017 13:48:46 -0400 Received: from 2.mo177.mail-out.ovh.net ([178.33.109.80]:38196 "EHLO 2.mo177.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755987AbdDPRso (ORCPT ); Sun, 16 Apr 2017 13:48:44 -0400 X-Greylist: delayed 2399 seconds by postgrey-1.27 at vger.kernel.org; Sun, 16 Apr 2017 13:48:44 EDT Subject: Re: [PATCH v4 2/2] mtd: spi-nor: add driver for STM32 quad spi flash controller To: Marek Vasut , Ludovic Barre , Cyrille Pitchen References: <1492103757-22375-1-git-send-email-ludovic.Barre@st.com> <1492103757-22375-3-git-send-email-ludovic.Barre@st.com> Cc: Boris Brezillon , Alexandre Torgue , devicetree@vger.kernel.org, Richard Weinberger , linux-kernel@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse From: Cyrille Pitchen Message-ID: Date: Sun, 16 Apr 2017 19:11:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 11955931113590576997 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeliedrvdeggddutdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, Le 14/04/2017 à 18:15, Marek Vasut a écrit : > On 04/13/2017 07:15 PM, Ludovic Barre wrote: >> From: Ludovic Barre >> >> The quadspi is a specialized communication interface targeting single, >> dual or quad SPI Flash memories. >> >> It can operate in any of the following modes: >> -indirect mode: all the operations are performed using the quadspi >> registers >> -read memory-mapped mode: the external Flash memory is mapped to the >> microcontroller address space and is seen by the system as if it was >> an internal memory >> >> Signed-off-by: Ludovic Barre > > Reviewed-by: Marek Vasut > Applied to github/spi-nor About patch 1, I wait for Rob's acknowledgement before merging it into the next branch of github/spi-nor but I'd rather take patch 2 now since it has been reviewed by Marek and integration issues would be detected sooner with linux-next so we would have more time to adapt this patch, if needed. I've already compile this patch inside the next branch of github/spi-nor and no warning was risen so I think there should be any issue. Hence if no integration issue is detected, I'll try to add it into the next spi-nor PR for 4.12. Best regards, Cyrille