From: Mike Kravetz <email@example.com> To: Vlastimil Babka <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Cc: Hillf Danton <email@example.com>, Michal Hocko <firstname.lastname@example.org>, Mel Gorman <email@example.com>, Johannes Weiner <firstname.lastname@example.org>, Andrea Arcangeli <email@example.com>, David Rientjes <firstname.lastname@example.org>, Andrew Morton <email@example.com> Subject: Re: [PATCH 3/3] hugetlbfs: don't retry when pool page allocations start to fail Date: Mon, 5 Aug 2019 10:12:00 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 8/5/19 2:28 AM, Vlastimil Babka wrote: > On 8/3/19 12:39 AM, Mike Kravetz wrote: >> When allocating hugetlbfs pool pages via /proc/sys/vm/nr_hugepages, >> the pages will be interleaved between all nodes of the system. If >> nodes are not equal, it is quite possible for one node to fill up >> before the others. When this happens, the code still attempts to >> allocate pages from the full node. This results in calls to direct >> reclaim and compaction which slow things down considerably. >> >> When allocating pool pages, note the state of the previous allocation >> for each node. If previous allocation failed, do not use the >> aggressive retry algorithm on successive attempts. The allocation >> will still succeed if there is memory available, but it will not try >> as hard to free up memory. >> >> Signed-off-by: Mike Kravetz <firstname.lastname@example.org> > > Looks like only part of the (agreed with) suggestions were implemented? My bad, I pulled in the wrong patch. > - set_max_huge_pages() returns -ENOMEM if nodemask can't be allocated, > but hugetlb_hstate_alloc_pages() doesn't. That is somewhat intentional. The calling context of the two routines is significantly different. hugetlb_hstate_alloc_pages is called at boot time to handle command line parameters. And, hugetlb_hstate_alloc_pages does not return a value as it is of type void. We 'could' print out a warning here. But, if we can't allocate a node mask I am pretty sure we will not be able to boot. I will add a comment. > - there's still __GFP_NORETRY in nodemask allocations > - (cosmetics) Mel pointed out that NODEMASK_FREE() works fine with NULL > pointers -- Mike Kravetz
prev parent reply other threads:[~2019-08-05 17:12 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-02 22:39 [PATCH 0/3] address hugetlb page allocation stalls Mike Kravetz 2019-08-02 22:39 ` [PATCH 1/3] mm, reclaim: make should_continue_reclaim perform dryrun detection Mike Kravetz 2019-08-05 8:42 ` Vlastimil Babka 2019-08-05 10:57 ` Vlastimil Babka 2019-08-05 16:58 ` Mike Kravetz 2019-08-05 18:34 ` Vlastimil Babka 2019-08-05 16:54 ` Mike Kravetz 2019-08-02 22:39 ` [PATCH 2/3] mm, compaction: raise compaction priority after it withdrawns Mike Kravetz 2019-08-05 9:14 ` Vlastimil Babka 2019-08-02 22:39 ` [PATCH 3/3] hugetlbfs: don't retry when pool page allocations start to fail Mike Kravetz 2019-08-05 9:28 ` Vlastimil Babka 2019-08-05 17:12 ` Mike Kravetz [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 3/3] hugetlbfs: don'\''t retry when pool page allocations start to fail' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).