From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B16C3B1BF for ; Sun, 16 Feb 2020 21:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E403A2084E for ; Sun, 16 Feb 2020 21:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727944AbgBPVtn (ORCPT ); Sun, 16 Feb 2020 16:49:43 -0500 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:40391 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbgBPVtm (ORCPT ); Sun, 16 Feb 2020 16:49:42 -0500 Received: from [78.134.119.80] (port=47944 helo=[192.168.77.51]) by hostingweb31.netsons.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1j3RnH-00HafO-Va; Sun, 16 Feb 2020 22:49:40 +0100 Subject: Re: [PATCH AUTOSEL 5.5 495/542] docs: i2c: writing-clients: properly name the stop condition To: Jean Delvare , Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org References: <20200214154854.6746-1-sashal@kernel.org> <20200214154854.6746-495-sashal@kernel.org> <20200215071402.027c9120@endymion> From: Luca Ceresoli Message-ID: Date: Sun, 16 Feb 2020 22:49:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200215071402.027c9120@endymion> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 15/02/20 07:14, Jean Delvare wrote: > On Fri, 14 Feb 2020 10:48:07 -0500, Sasha Levin wrote: >> From: Luca Ceresoli >> >> [ Upstream commit 4fcb445ec688a62da9c864ab05a4bd39b0307cdc ] >> >> In I2C there is no such thing as a "stop bit". Use the proper naming: "stop >> condition". >> >> Signed-off-by: Luca Ceresoli >> Reported-by: Jean Delvare >> Reviewed-by: Jean Delvare >> Signed-off-by: Wolfram Sang >> Signed-off-by: Sasha Levin >> --- >> Documentation/i2c/writing-clients.rst | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/i2c/writing-clients.rst b/Documentation/i2c/writing-clients.rst >> index ced309b5e0cc8..3869efdf84cae 100644 >> --- a/Documentation/i2c/writing-clients.rst >> +++ b/Documentation/i2c/writing-clients.rst >> @@ -357,9 +357,9 @@ read/written. >> >> This sends a series of messages. Each message can be a read or write, >> and they can be mixed in any way. The transactions are combined: no >> -stop bit is sent between transaction. The i2c_msg structure contains >> -for each message the client address, the number of bytes of the message >> -and the message data itself. >> +stop condition is issued between transaction. The i2c_msg structure >> +contains for each message the client address, the number of bytes of the >> +message and the message data itself. >> >> You can read the file ``i2c-protocol`` for more information about the >> actual I2C protocol. > > I wouldn't bother backporting this documentation patch to stable and > longterm trees. That's a minor vocabulary thing really, it does not > qualify. I also feel no need to have it in stable branches. Hovever it would not hurt, so whatever is fine for who's maintaining that branch will be fine for me as well. -- Luca