From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757879AbcIXPci (ORCPT ); Sat, 24 Sep 2016 11:32:38 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:59351 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbcIXPcd (ORCPT ); Sat, 24 Sep 2016 11:32:33 -0400 Subject: Re: [PATCH 2/7] iio: Rename a jump label in iio_buffer_store_watermark() To: SF Markus Elfring , linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler References: <566ABCD9.1060404@users.sourceforge.net> <50eb1352-fb0a-1cf5-70d8-48fe8f98b9eb@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Jonathan Cameron Message-ID: Date: Sat, 24 Sep 2016 16:32:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <50eb1352-fb0a-1cf5-70d8-48fe8f98b9eb@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/09/16 07:25, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 06:54:49 +0200 > > Adjust jump labels according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring I'm not necessarily against this change which does perhaps clarify the code ever so slightly, but I am interested to know where 'current Linux coding style convention' comes from? Jonathan > --- > drivers/iio/industrialio-buffer.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c > index 7a4d9499..a865af8 100644 > --- a/drivers/iio/industrialio-buffer.c > +++ b/drivers/iio/industrialio-buffer.c > @@ -1028,16 +1028,16 @@ static ssize_t iio_buffer_store_watermark(struct device *dev, > > if (val > buffer->length) { > ret = -EINVAL; > - goto out; > + goto unlock; > } > > if (iio_buffer_is_active(indio_dev->buffer)) { > ret = -EBUSY; > - goto out; > + goto unlock; > } > > buffer->watermark = val; > -out: > +unlock: > mutex_unlock(&indio_dev->mlock); > > return ret ? ret : len; >