From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Philipp Zabel <p.zabel@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Stuebner <heiko@sntech.de>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: nicolas@ndufresne.ca, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 05/24] media: h264: Use v4l2_h264_reference for reflist
Date: Thu, 5 May 2022 03:42:03 +0300 [thread overview]
Message-ID: <dfda7666-7325-f4a1-69b1-6b3cb9701b62@collabora.com> (raw)
In-Reply-To: <20220426125751.108293-6-nicolas.dufresne@collabora.com>
On 4/26/22 15:57, Nicolas Dufresne wrote:
> static int tegra_vde_wait_mbe(struct tegra_vde *vde)
> @@ -768,7 +768,7 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx,
> struct h264_reflists reflists;
> struct vb2_buffer *ref;
> unsigned int i;
> - u8 *dpb_id;
> + struct v4l2_h264_reference *dpb_id;
nit: will be nice to preserve to reverse Xmas coding style, but only if
you'll need to make v5 with more important changes
> int err;
>
> /*
> @@ -811,14 +811,16 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx,
> }
>
> for (i = 0; i < b.num_valid; i++) {
> - ref = get_ref_buf(ctx, dst, dpb_id[i]);
> + int dpb_idx = dpb_id[i].index;
>
> - err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_id[i],
> + ref = get_ref_buf(ctx, dst, dpb_idx);
> +
> + err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_idx,
> h264->dpb_frames_nb++);
> if (err)
> return err;
>
> - if (b.refs[dpb_id[i]].pic_order_count < b.cur_pic_order_count)
> + if (b.refs[dpb_idx].top_field_order_cnt < b.cur_pic_order_count)
> h264->dpb_ref_frames_with_earlier_poc_nb++;
Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
next prev parent reply other threads:[~2022-05-05 0:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 12:57 [PATCH v4 00/24] H.264 Field Decoding Support for Frame-based Decoders Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 01/24] media: doc: Document dual use of H.264 pic_num/frame_num Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 02/24] media: v4l2-mem2mem: Trace on implicit un-hold Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 03/24] media: videobuf2-v4l2: Warn on holding buffers without support Nicolas Dufresne
2022-04-27 4:31 ` Tomasz Figa
2022-04-27 15:08 ` Nicolas Dufresne
2022-04-28 6:12 ` Hans Verkuil
2022-04-28 13:09 ` Nicolas Dufresne
2022-11-24 8:57 ` Hans Verkuil
2022-04-26 12:57 ` [PATCH v4 04/24] media: h264: Avoid wrapping long_term_frame_idx Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 05/24] media: h264: Use v4l2_h264_reference for reflist Nicolas Dufresne
2022-05-05 0:42 ` Dmitry Osipenko [this message]
2022-04-26 12:57 ` [PATCH v4 06/24] media: h264: Increase reference lists size to 32 Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 07/24] media: h264: Store current picture fields Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 08/24] media: h264: Store all fields into the unordered list Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 09/24] media: v4l2: Trace calculated p/b0/b1 initial reflist Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 10/24] media: h264: Sort p/b reflist using frame_num Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 11/24] media: v4l2: Reorder field reflist Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 12/24] media: rkvdec: Stop overclocking the decoder Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 13/24] media: rkvdec: h264: Fix dpb_valid implementation Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 14/24] media: rkvdec: h264: Fix bit depth wrap in pps packet Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 15/24] media: rkvdec: Move H264 SPS validation in rkvdec-h264 Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 16/24] media: rkvdec: h264: Validate and use pic width and height in mbs Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 17/24] media: rkvdec: h264: Fix reference frame_num wrap for second field Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 18/24] media: rkvdec: Ensure decoded resolution fit coded resolution Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 19/24] media: rkvdec-h264: Add field decoding support Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 20/24] media: rkvdec: Enable capture buffer holding for H264 Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 21/24] media: hantro: Stop using H.264 parameter pic_num Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 22/24] media: hantro: h264: Make dpb entry management more robust Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 23/24] media: hantro: Add H.264 field decoding support Nicolas Dufresne
2022-04-28 8:50 ` Hans Verkuil
2022-04-28 13:10 ` Nicolas Dufresne
2022-04-26 12:57 ` [PATCH v4 24/24] media: hantro: Enable HOLD_CAPTURE_BUF for H.264 Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfda7666-7325-f4a1-69b1-6b3cb9701b62@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=digetx@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).