From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754149AbcICTBy (ORCPT ); Sat, 3 Sep 2016 15:01:54 -0400 Received: from mout.web.de ([212.227.17.11]:56479 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753684AbcICTBu (ORCPT ); Sat, 3 Sep 2016 15:01:50 -0400 Subject: [PATCH 1/2] tile-module: Use kmalloc_array() in module_alloc() To: Chris Metcalf , Rusty Russell References: <566ABCD9.1060404@users.sourceforge.net> <764e5d1b-c7ab-c8aa-1482-334a00e11280@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Sat, 3 Sep 2016 21:01:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <764e5d1b-c7ab-c8aa-1482-334a00e11280@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:4JZk3NLuCKyPDN1KTi6R2NJSkSAgC6DL1QQIS9X5Q0wvmiMklu+ tGajdYuJ2orUkkIZMAROdMVNR8IK2aKP1EHjLBOoNGIGLR/53h4Ja7lawJLaD/Jl+0sqL9F NOmbbtMUr37VxPYAii6HgA1QscbTApuHls1PiIU4gb+VBmMmJXxyDPVoKp55x2uLy71piQw C8EgV6IwaJMAq/C3VeLkQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:b6ZvA41iGzw=:0hf8zEvP233+umMuTcRKwK AM/F9krF+xIL0jFQpTWBBdSJLr0gR9eCpWX3/0+wPkWcrdUHg2D+M6UvDSYCGDYrILtEhHSf9 WJei3ogIQE9BXW29eDmRCV6qehZD+JSZdcS3npJOVaOFfkUGeZOhmJPYTAOxhAfUCK2U5bOap QHoXMfcJOdSB99MdkraaQp9t/isMx2Jm+xWSYvmdUhDaP1Q3McRqelQT8oGImKzEPRK35SZOG 8rBsjVZ+BykANQmXXXNIcWAlW4xSncf+VtsoAicOd7C2gC08fF05uyvS/5N90bY4KlJ+NF5ly 5SZiBHkU9ZgM+of4Z/8K7Pn4tch+JdBDZ2q5QboaCxAKKOvokwPAA8TjMDn+AStoQ2H13iqU2 skmiW27c2EaqnVAggBb9cLBms1EPOoF+7Vkt+5rOLO9mPz1zkVV1oB7f3IRCXZVILMrmmqPRj xFPsy/F1zZHvNhIhpMbRrdCQjvIXrJqUsYIDcwPEn2izcgsJSaoFipqDuJtbMiYIDWaEioilF 0223rzawBl8w01bLlbVcHPkcA+q9lwnrTwj85uzmJQmTa5HKuB2IZ7rNGTmdagAFltFO8WcQA C32PsFf6J0Me0CxwjFuFQQ2w60JtEgg31obmgd6j4lr2GQLooQlqxB8FWD0lU//lcXVsnrp51 cAcxBh51DITWKiQ0ScOf2gVkyVfRR49F4tAtAjw12P0Ma8dbSPV6Gu/75OdsZcUC7FCAm6SLe h78i5CnYNWBvDFilb/y7QUzXiJ14IMPnEkIPR9ENeLpYqyba2yQKQNZTxTzzu8sxLC6wZYWRy BjKZAAb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 3 Sep 2016 20:40:57 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/tile/kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/tile/kernel/module.c b/arch/tile/kernel/module.c index 2305084..dce4120 100644 --- a/arch/tile/kernel/module.c +++ b/arch/tile/kernel/module.c @@ -43,7 +43,7 @@ void *module_alloc(unsigned long size) int npages; npages = (size + PAGE_SIZE - 1) / PAGE_SIZE; - pages = kmalloc(npages * sizeof(struct page *), GFP_KERNEL); + pages = kmalloc_array(npages, sizeof(*pages), GFP_KERNEL); if (pages == NULL) return NULL; for (; i < npages; ++i) { -- 2.9.3